You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/08 12:38:57 UTC
[GitHub] [superset] ofekisr opened a new pull request #17687: chore: removing redundant docker-entrypoint
ofekisr opened a new pull request #17687:
URL: https://github.com/apache/superset/pull/17687
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AndreyRomanchev commented on pull request #17687: chore: removing redundant docker-entrypoint
Posted by GitBox <gi...@apache.org>.
AndreyRomanchev commented on pull request #17687:
URL: https://github.com/apache/superset/pull/17687#issuecomment-989201672
helm chart uses tag latest (not a great thing), so old superset helm installations will fail with error
```/bin/sh: 1: /usr/bin/docker-entrypoint.sh: not found```
if the new image will be downloaded for some reason (pod restart or schedule to new node for example)
I upgraded helm chart from 0.3.10 to 0.5.0, this resolved the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] layoaster edited a comment on pull request #17687: chore: removing redundant docker-entrypoint
Posted by GitBox <gi...@apache.org>.
layoaster edited a comment on pull request #17687:
URL: https://github.com/apache/superset/pull/17687#issuecomment-1010085045
the [image](https://hub.docker.com/layers/apache/superset/1.3.2/images/sha256-459c653ce3db6931bd7f9911e2fbfb93f5385f815cddf63a897fcbc6d1d73f33?context=explore) for Superset version 1.3.2 is not updated with these changes.
My values.yaml:
```yaml
image:
repository: apache/superset
tag: "1.3.2"
pullPolicy: IfNotPresent
```
What official image tag should I use to get the latest Superset version working with this chart version ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a change in pull request #17687: chore: removing redundant docker-entrypoint
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #17687:
URL: https://github.com/apache/superset/pull/17687#discussion_r768840426
##########
File path: docker/docker-bootstrap.sh
##########
@@ -47,5 +47,5 @@ elif [[ "${1}" == "app" ]]; then
flask run -p 8088 --with-threads --reload --debugger --host=0.0.0.0
elif [[ "${1}" == "app-gunicorn" ]]; then
echo "Starting web app..."
- /app/docker/docker-entrypoint.sh
+ /usr/bin/run-server.sh
Review comment:
Try running `docker-compose pull` first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 merged pull request #17687: chore: removing redundant docker-entrypoint
Posted by GitBox <gi...@apache.org>.
amitmiran137 merged pull request #17687:
URL: https://github.com/apache/superset/pull/17687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] layoaster edited a comment on pull request #17687: chore: removing redundant docker-entrypoint
Posted by GitBox <gi...@apache.org>.
layoaster edited a comment on pull request #17687:
URL: https://github.com/apache/superset/pull/17687#issuecomment-1010085045
the [image](https://hub.docker.com/layers/apache/superset/1.3.2/images/sha256-459c653ce3db6931bd7f9911e2fbfb93f5385f815cddf63a897fcbc6d1d73f33?context=explore) for Superset version 1.3.2 is not updated with these changes.
My values.yaml:
```yaml
image:
repository: apache/superset
tag: "1.3.2"
pullPolicy: IfNotPresent
```
What official image tag should I use to get the Superset version 1.3.2 working with this chart version ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] msxiehui commented on a change in pull request #17687: chore: removing redundant docker-entrypoint
Posted by GitBox <gi...@apache.org>.
msxiehui commented on a change in pull request #17687:
URL: https://github.com/apache/superset/pull/17687#discussion_r775423318
##########
File path: docker/docker-bootstrap.sh
##########
@@ -47,5 +47,5 @@ elif [[ "${1}" == "app" ]]; then
flask run -p 8088 --with-threads --reload --debugger --host=0.0.0.0
elif [[ "${1}" == "app-gunicorn" ]]; then
echo "Starting web app..."
- /app/docker/docker-entrypoint.sh
+ /usr/bin/run-server.sh
Review comment:
>
macOS
/usr/bin/run-server.sh -> sh /app/docker/run-server.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] layoaster commented on pull request #17687: chore: removing redundant docker-entrypoint
Posted by GitBox <gi...@apache.org>.
layoaster commented on pull request #17687:
URL: https://github.com/apache/superset/pull/17687#issuecomment-1010085045
the [image](https://hub.docker.com/layers/apache/superset/1.3.2/images/sha256-459c653ce3db6931bd7f9911e2fbfb93f5385f815cddf63a897fcbc6d1d73f33?context=explore) for Superset version 1.3.2 is not updated with these changes.
My values.yaml:
```yaml
image:
repository: apache/superset
tag: "1.3.2"
pullPolicy: IfNotPresent
```
What official image tag should I use to get the latest version working with this chart version ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] d9k commented on a change in pull request #17687: chore: removing redundant docker-entrypoint
Posted by GitBox <gi...@apache.org>.
d9k commented on a change in pull request #17687:
URL: https://github.com/apache/superset/pull/17687#discussion_r768817116
##########
File path: docker/docker-bootstrap.sh
##########
@@ -47,5 +47,5 @@ elif [[ "${1}" == "app" ]]; then
flask run -p 8088 --with-threads --reload --debugger --host=0.0.0.0
elif [[ "${1}" == "app-gunicorn" ]]; then
echo "Starting web app..."
- /app/docker/docker-entrypoint.sh
+ /usr/bin/run-server.sh
Review comment:
Having trouble starting docker composer due to this fix:
```
/app/docker/docker-bootstrap.sh: line 50: /usr/bin/run-server.sh: No such file or directory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org