You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/05/19 13:51:47 UTC
[GitHub] [incubator-eventmesh] ruanwenjun opened a new issue #359: Split handler form ClientManageController
ruanwenjun opened a new issue #359:
URL: https://github.com/apache/incubator-eventmesh/issues/359
Split handler from controller, make the controller code more concise, and it is convenient to write unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on issue #359: Split handler form ClientManageController
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #359:
URL: https://github.com/apache/incubator-eventmesh/issues/359#issuecomment-845011908
@lrhkobe Maybe you are right, if you are sure that this change is not necessary, you can close this issue, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on issue #359: Split handler form ClientManageController
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on issue #359:
URL: https://github.com/apache/incubator-eventmesh/issues/359#issuecomment-845019593
@ruanwenjun Your idea is good, discuss is open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] lrhkobe commented on issue #359: Split handler form ClientManageController
Posted by GitBox <gi...@apache.org>.
lrhkobe commented on issue #359:
URL: https://github.com/apache/incubator-eventmesh/issues/359#issuecomment-845036215
@ruanwenjun Can you offer some unit test demo which is mentioned in this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #359: Split handler form ClientManageController
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #359:
URL: https://github.com/apache/incubator-eventmesh/issues/359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] lrhkobe commented on issue #359: Split handler form ClientManageController
Posted by GitBox <gi...@apache.org>.
lrhkobe commented on issue #359:
URL: https://github.com/apache/incubator-eventmesh/issues/359#issuecomment-844928781
@ruanwenjun I think it is unnecessary to split the controller,because the cotroller is just as a tool class ,not associcatesd with business, and it's function may be certain.Split it may lead to an increase in the number of classes and system complexity.
About it is more convenient to write unit test? I have not got it,, can you make it clear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on issue #359: Split handler form ClientManageController
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #359:
URL: https://github.com/apache/incubator-eventmesh/issues/359#issuecomment-844852847
@qqeasonchen I think it can also make the controller cleaner, if we need to add new handler in the future, we don't want to write it in the controller, because if we do this, the controller will become a huge class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on issue #359: Split handler form ClientManageController
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on issue #359:
URL: https://github.com/apache/incubator-eventmesh/issues/359#issuecomment-844826737
Just for UT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on issue #359: Split handler form ClientManageController
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #359:
URL: https://github.com/apache/incubator-eventmesh/issues/359#issuecomment-845212085
@lrhkobe Ok, I have written a simple unit test.

This code just tests one simple case, in each handler, there may be multiple cases that need to be tested.
I think if We test all handlers in one controller class, this may make the controller class very complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org