[GitHub] [airflow] mik-laj commented on a change in pull request #15438: Speeds up Docker build process by combining RUN and ENV commands

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #15438:
URL: https://github.com/apache/airflow/pull/15438#discussion_r616264905



##########
File path: Dockerfile
##########
@@ -106,21 +102,19 @@ ARG DEV_APT_DEPS="\
      unixodbc \
      unixodbc-dev \
      yarn"
-ENV DEV_APT_DEPS=${DEV_APT_DEPS}
-
 ARG ADDITIONAL_DEV_APT_DEPS=""
-ENV ADDITIONAL_DEV_APT_DEPS=${ADDITIONAL_DEV_APT_DEPS}
-
 ARG DEV_APT_COMMAND="\
     curl --fail --location https://deb.nodesource.com/setup_10.x | bash - \
     && curl https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - > /dev/null \
     && echo 'deb https://dl.yarnpkg.com/debian/ stable main' > /etc/apt/sources.list.d/yarn.list"
-ENV DEV_APT_COMMAND=${DEV_APT_COMMAND}
-
 ARG ADDITIONAL_DEV_APT_COMMAND="echo"
-ENV ADDITIONAL_DEV_APT_COMMAND=${ADDITIONAL_DEV_APT_COMMAND}
 
-ARG ADDITIONAL_DEV_APT_ENV=""
+ENV DEV_APT_DEPS=${DEV_APT_DEPS}

Review comment:
       Why 2 layers? Should we combine 112 and 114 into one step?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org