[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #589: Mod: update the comments in registy directory

[GitBox <gi...@apache.org>]

AlexStocks commented on a change in pull request #589:
URL: https://github.com/apache/dubbo-go/pull/589#discussion_r436446891



##########
File path: registry/protocol/protocol.go
##########
@@ -411,6 +416,8 @@ func newProviderConfigurationListener(overrideListeners *sync.Map) *providerConf
 	return listener
 }
 
+// Process is Listener callback method. Listener gets notified by this method once there's any change happens on the config

Review comment:
       so long

##########
File path: registry/registry.go
##########
@@ -45,13 +45,21 @@ type Registry interface {
 	Subscribe(*common.URL, NotifyListener)
 }
 
-// NotifyListener ...
+// NotifyListener is used for triggered when a service change notification is received.
 type NotifyListener interface {
+	// Notify needs to support the contract: <br>

Review comment:
       so lang.

##########
File path: config_center/configuration_listener.go
##########
@@ -27,6 +27,8 @@ import (
 
 // ConfigurationListener for changing listener's event
 type ConfigurationListener interface {
+	// Process is Listener callback method. Listener gets notified by this method once there's any change happens on the config

Review comment:
       so long.

##########
File path: registry/protocol/protocol.go
##########
@@ -435,6 +442,8 @@ func newServiceConfigurationListener(overrideListener *overrideSubscribeListener
 	return listener
 }
 
+// Process is Listener callback method. Listener gets notified by this method once there's any change happens on the config

Review comment:
       so long.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org