You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "MartinWitt (via GitHub)" <gi...@apache.org> on 2023/05/29 11:27:05 UTC

[GitHub] [maven-dependency-plugin] MartinWitt commented on a diff in pull request #325: [MDEP-799] tree: add optional output type json

MartinWitt commented on code in PR #325:
URL: https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1209218850


##########
src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java:
##########
@@ -380,6 +380,8 @@ public DependencyNodeVisitor getSerializingDependencyNodeVisitor(Writer writer)
             return new TGFDependencyNodeVisitor(writer);
         } else if ("dot".equals(outputType)) {
             return new DOTDependencyNodeVisitor(writer);
+        } else if ("json".equals(outputType)) {
+            return new JsonDependencyNodeVisitor(writer);
         } else {
             return new SerializingDependencyNodeVisitor(writer, toGraphTokens(tokens));

Review Comment:
   In the other PR someone asked for a switch case instead. Shall I convert this to a switch statement?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org