[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1368: SOLR-14351: Fix/improve MDCLoggingContext usage

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #1368: SOLR-14351: Fix/improve MDCLoggingContext usage
URL: https://github.com/apache/lucene-solr/pull/1368#discussion_r398887911
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java
 ##########
 @@ -615,7 +614,7 @@ public Action call() throws IOException {
       }
       return RETURN;
     } finally {
-      MDCLoggingContext.clear();
+      MDCLoggingContext.clear(); // admittedly setCore might not have been called but that's okay.
 
 Review comment:
   This probably isn't needed anymore either

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org