[GitHub] [helix] zhangmeng916 commented on a change in pull request #992: Fix version comparison issue in compatibility check stage

[GitBox <gi...@apache.org>]

zhangmeng916 commented on a change in pull request #992:
URL: https://github.com/apache/helix/pull/992#discussion_r419611245



##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/CompatibilityCheckStage.java
##########
@@ -55,7 +55,7 @@ public void process(ClusterEvent event) throws Exception {
             "incompatible participant. pipeline will not continue. " + "controller: "
                 + manager.getInstanceName() + ", controllerVersion: " + properties.getVersion()
                 + ", minimumSupportedParticipantVersion: "
-                + properties.getProperty("miminum_supported_version.participant")
+                + properties.getProperty("minimum_supported_version.participant")

Review comment:
       The previous one has a typo.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org