You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/03/10 12:32:03 UTC

[GitHub] [tinkerpop] FlorianHockmann opened a new pull request #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0

FlorianHockmann opened a new pull request #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0
URL: https://github.com/apache/tinkerpop/pull/1260
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2335
   
   This handles the .NET part of TINKERPOP-2335 by removing support for .NET Standard 1.3. This makes it easier for us to use newer .NET features in the future.
   
   I also updated all .NET Core versions to the latest LTS version which is 3.1 right now. This includes the test projects, the dotnet template, the Travis file and our Docker build.
   Unfortunately, I cannot try the Docker build right now as it isn't working for me on `master` at the moment. I'll add results of that once the Docker build is working again for me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] FlorianHockmann commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0

Posted by GitBox <gi...@apache.org>.

FlorianHockmann commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0
URL: https://github.com/apache/tinkerpop/pull/1260#issuecomment-597606170
 
 
   `docker/build.sh -t` now also succeeds after I rebased on `master` given [the change](https://github.com/apache/tinkerpop/commit/6735fabe94c1ac227d07a5ae91bb15c1eb202a62) from @spmallette to fix the Docker build.
   
   So, I'm adding my VOTE +1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] FlorianHockmann merged pull request #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0

Posted by GitBox <gi...@apache.org>.

FlorianHockmann merged pull request #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0
URL: https://github.com/apache/tinkerpop/pull/1260
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] spmallette commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0

Posted by GitBox <gi...@apache.org>.

spmallette commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0
URL: https://github.com/apache/tinkerpop/pull/1260#issuecomment-598115481
 
 
   Sorry, I don't mean to be confusing. Perhaps I'm just projecting what I know of python/jdk versioning on to this change and that I simply have the wrong understanding of the context for .NET. If using the new .NET SDK on the older branches doesn't increase our risk of things not working then that's fine to me. 
   
   VOTE +1
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] spmallette commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0

Posted by GitBox <gi...@apache.org>.

spmallette commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0
URL: https://github.com/apache/tinkerpop/pull/1260#issuecomment-597607100
 
 
   does this mean that we have to install multiple versions of .NET to build on the different branches?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] spmallette commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0

Posted by GitBox <gi...@apache.org>.

spmallette commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0
URL: https://github.com/apache/tinkerpop/pull/1260#issuecomment-597752979
 
 
   yes - i'd like to try to keep one docker image for building, which is why i went to extremes to manually install the exact version of python we needed. if SDK 3.1 builds all the release branches then i guess we should go with that across the board. i guess the only downside is that we don't test the older branches explicitly with the version we say we support. 
   
   i'm not sure at what point we "fork" our docker images across branches...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] FlorianHockmann commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0

Posted by GitBox <gi...@apache.org>.

FlorianHockmann commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0
URL: https://github.com/apache/tinkerpop/pull/1260#issuecomment-598155696

No worries. I can just try to explain it a bit more detailed as .NET versioning / targeting can be confusing:

Gremlin.NET targets .NET Standard 1.3 and .NET Standard 2.0 right now. Users will include it in their applications that run on a .NET platform like .NET Core, .NET Framework, Mono or Xamarin. This PR drops support for .NET Standard 1.3 on `master` for TinkerPop 3.5.0. That has the effect that for example .NET Core 1.0 is not supported any more and users have to update to .NET Core 2.0 or higher. Since .NET Core 2.0 was released in October 2018 and .NET Core 1.x reached EOL in June 2019, that shouldn't be a big problem. The situation is similar for .NET Framework, Mono and the other platforms. .NET Standard was for example supported by .NET Framework since version 4.6.0, but .NET Standard is only supported since version 4.6.1.
This information can be found for all .NET Standard versions and platforms [in this table](https://docs.microsoft.com/en-us/dotnet/standard/net-standard#net-implementation-support).

While we only target .NET Standard with Gremlin.NET, we still need a platform to execute our tests on and to build the project. We use .NET Core for that as it's OS independent and because all .NET platforms seem to be slowly merging into .NET Core, resulting in [.NET 5](https://devblogs.microsoft.com/dotnet/introducing-net-5/) which will hopefully also make the .NET ecosystem easier to understand.
#1261 now updates our usages of .NET Core from 2.0 to 3.1 so we have the most recent SDK to build the project and to run the tests on .NET Core 3.1.
We can do that on all release branches because it really only affects our development process (apart from Gremlin.NET template).

And after #1261 is merged, this PR will really only drop support for .NET Standard 1.3.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [tinkerpop] FlorianHockmann commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0

Posted by GitBox <gi...@apache.org>.

FlorianHockmann commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0
URL: https://github.com/apache/tinkerpop/pull/1260#issuecomment-597098746
 
 
   > Did you happen to verify if there were any issues with docfx generation as a result of this change?
   
   That shouldn't be affected from what I know. Just to be sure I also just built the docs again on this branch and it succeeded.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] FlorianHockmann commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0

Posted by GitBox <gi...@apache.org>.

FlorianHockmann commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0
URL: https://github.com/apache/tinkerpop/pull/1260#issuecomment-598088623
 
 
   > i guess the only downside is that we don't test the older branches explicitly with the version we say we support.
   
   What do you mean with _the version we say we support_? TinkerPop versions of past releases or .NET Core versions?
   I don't really see a difference to be honest as we have only tested Gremlin.NET with a single .NET Core version in the past already. We just change that version now from 2.0 to 3.1.
   And where do we say which versions we support? For TinkerPop versions, I only see the _Current Releases_ section on the [download page](http://tinkerpop.apache.org/downloads.html) and for Gremlin, we only supported .NET Standard versions explicitly and that doesn't really change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] FlorianHockmann commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0

Posted by GitBox <gi...@apache.org>.

FlorianHockmann commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0
URL: https://github.com/apache/tinkerpop/pull/1260#issuecomment-597718422

> does this mean that we have to install multiple versions of .NET to build on the different branches?

Good question. My understanding was always that the .NET Core SDK is completely backwards compatible which was correct, but what I didn't know is that that doesn't apply to the .NET Core runtimes which we need to execute the tests. I just tried to run the Gremlin.NET tests on `3.4-dev` with only .NET Core SDK 3.1 installed and it failed.

So, I guess that the best approach is now to update all release branches to .NET Core 3.1 which is the latest LTS version.
This has no effect on users of Gremlin.Net as that targets .NET Standard which doesn't need to be changed at all. The only change affecting users is the update in Gremlin.Net.Template, but that is a good thing in my opinion as the template is only used to create a completely new project and then using the latest LTS version sounds like the best approach to me.

Unless there are any concerns with this approach, I'm going to create a PR that targets `3.3-dev` and update to .NET Core 3.1 there. We can then merge that PR first into all release branches and I will rebase this PR afterwards. That means that all contributors (only) need .NET Core SDK 3.1 for all release branches afterwards.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [tinkerpop] spmallette commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0

Posted by GitBox <gi...@apache.org>.

spmallette commented on issue #1260: TINKERPOP-2335 Drop support for .NET Standard <2.0
URL: https://github.com/apache/tinkerpop/pull/1260#issuecomment-597066140
 
 
   Did you happen to verify if there were any issues with docfx generation as a result of this change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services