You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "sun qiao yun (JIRA)" <ji...@apache.org> on 2010/11/10 11:01:14 UTC
[jira] Created: (SHINDIG-1466) make gadget.util a singleton which
will not impact the iframe rendering
make gadget.util a singleton which will not impact the iframe rendering
-----------------------------------------------------------------------
Key: SHINDIG-1466
URL: https://issues.apache.org/jira/browse/SHINDIG-1466
Project: Shindig
Issue Type: Improvement
Components: Javascript
Reporter: sun qiao yun
registerOnLoadHandler and runOnLoadHandlers: this two functions used an array "onLoadHandlers" to store and read the registered handlers and this is a locally variable. When rendering in iframe, the outside util and inside util are isolated, all theirs registered handler will be run. But when rendering inline, the inside util will rewrite the outside util due to the context merge issue described above, so the outside util's registered handler will not be run.
if make gadgets.util, there is only one gadgets.util, and iframe rendering can't be effected, as it still will create one in the gadget.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1466) make gadget.util a singleton which
will not impact the iframe rendering
Posted by "sun qiao yun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930564#action_12930564 ]
sun qiao yun commented on SHINDIG-1466:
---------------------------------------
See the change :http://codereview.appspot.com/3014041/
> make gadget.util a singleton which will not impact the iframe rendering
> -----------------------------------------------------------------------
>
> Key: SHINDIG-1466
> URL: https://issues.apache.org/jira/browse/SHINDIG-1466
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Reporter: sun qiao yun
>
> registerOnLoadHandler and runOnLoadHandlers: this two functions used an array "onLoadHandlers" to store and read the registered handlers and this is a locally variable. When rendering in iframe, the outside util and inside util are isolated, all theirs registered handler will be run. But when rendering inline, the inside util will rewrite the outside util due to the context merge issue described above, so the outside util's registered handler will not be run.
> if make gadgets.util, there is only one gadgets.util, and iframe rendering can't be effected, as it still will create one in the gadget.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.