You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/28 08:09:40 UTC
[GitHub] [hadoop-ozone] smengcl opened a new pull request #876: HDDS-3389. Add response to SetVolumePropertyResponse proto
smengcl opened a new pull request #876:
URL: https://github.com/apache/hadoop-ozone/pull/876
## What changes were proposed in this pull request?
https://github.com/apache/hadoop-ozone/pull/806#discussion_r408279098
1. Add `optional bool response = 1;` in the message.
2. Handle the response on the client. e.g. in setOwner, if the response is false, we can print message: The specified user is already the owner of the volume.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3389
## How was this patch tested?
Not yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #876: HDDS-3389. Add response to SetVolumePropertyResponse proto
Posted by GitBox <gi...@apache.org>.
xiaoyuyao merged pull request #876:
URL: https://github.com/apache/hadoop-ozone/pull/876
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #876: HDDS-3389. Add response to SetVolumePropertyResponse proto
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on pull request #876:
URL: https://github.com/apache/hadoop-ozone/pull/876#issuecomment-628245657
LGTM, +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #876: HDDS-3389. Add response to SetVolumePropertyResponse proto
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #876:
URL: https://github.com/apache/hadoop-ozone/pull/876#discussion_r424730653
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1690,14 +1690,10 @@ public boolean getAclsEnabled() {
}
/**
- * Changes the owner of a volume.
- *
- * @param volume - Name of the volume.
- * @param owner - Name of the owner.
- * @throws IOException
+ * {@inheritDoc}
*/
@Override
- public void setOwner(String volume, String owner) throws IOException {
+ public boolean setOwner(String volume, String owner) throws IOException {
Review comment:
Correction: Here is just to follow the change in `OzoneManagerServerProtocol`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #876: HDDS-3389. Add response to SetVolumePropertyResponse proto
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #876:
URL: https://github.com/apache/hadoop-ozone/pull/876#discussion_r422228479
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1690,14 +1690,10 @@ public boolean getAclsEnabled() {
}
/**
- * Changes the owner of a volume.
- *
- * @param volume - Name of the volume.
- * @param owner - Name of the owner.
- * @throws IOException
+ * {@inheritDoc}
*/
@Override
- public void setOwner(String volume, String owner) throws IOException {
+ public boolean setOwner(String volume, String owner) throws IOException {
Review comment:
Just curious if this ever return false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #876: HDDS-3389. Add response to SetVolumePropertyResponse proto
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #876:
URL: https://github.com/apache/hadoop-ozone/pull/876#discussion_r422291764
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1690,14 +1690,10 @@ public boolean getAclsEnabled() {
}
/**
- * Changes the owner of a volume.
- *
- * @param volume - Name of the volume.
- * @param owner - Name of the owner.
- * @throws IOException
+ * {@inheritDoc}
*/
@Override
- public void setOwner(String volume, String owner) throws IOException {
+ public boolean setOwner(String volume, String owner) throws IOException {
Review comment:
> Just curious if this ever return false?
Yes. It returns false when the given user is already the owner of the volume: https://github.com/apache/hadoop-ozone/pull/876/commits/4613bd0724ee0be97651aaa7364f3921436b9183#diff-990a43aeb92fe45392bdab4484ec488bR150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl commented on pull request #876: HDDS-3389. Add response to SetVolumePropertyResponse proto
Posted by GitBox <gi...@apache.org>.
smengcl commented on pull request #876:
URL: https://github.com/apache/hadoop-ozone/pull/876#issuecomment-628807039
Thanks @xiaoyuyao for reviewing and committing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org