You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/10/17 13:53:06 UTC
[GitHub] [cordova-js] raphinesse opened a new pull request #243: refactor(base64): factor out binary string <-> array buffer conversion
raphinesse opened a new pull request #243:
URL: https://github.com/apache/cordova-js/pull/243
This is a follow-up to #242 that tries to structure the base64 code more symmetrically by factoring out the conversion between binary strings and array buffers into dedicated functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-js] codecov-commenter edited a comment on pull request #243: refactor(base64): factor out binary string <-> array buffer conversion
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #243:
URL: https://github.com/apache/cordova-js/pull/243#issuecomment-945128623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-js] raphinesse merged pull request #243: refactor(base64): factor out binary string <-> array buffer conversion
Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #243:
URL: https://github.com/apache/cordova-js/pull/243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-js] codecov-commenter edited a comment on pull request #243: refactor(base64): factor out binary string <-> array buffer conversion
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #243:
URL: https://github.com/apache/cordova-js/pull/243#issuecomment-945128623
# [Codecov](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#243](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c4eea9) into [master](https://codecov.io/gh/apache/cordova-js/commit/d83f8d8e286018523f1696d39d5011d2b57575b8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d83f8d8) will **decrease** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 83.65% 83.62% -0.04%
==========================================
Files 14 14
Lines 520 519 -1
==========================================
- Hits 435 434 -1
Misses 85 85
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/common/base64.js](https://codecov.io/gh/apache/cordova-js/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbW1vbi9iYXNlNjQuanM=) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d83f8d8...4c4eea9](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-js] codecov-commenter commented on pull request #243: refactor(base64): factor out binary string <-> array buffer conversion
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #243:
URL: https://github.com/apache/cordova-js/pull/243#issuecomment-945128623
# [Codecov](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#243](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c4eea9) into [master](https://codecov.io/gh/apache/cordova-js/commit/d83f8d8e286018523f1696d39d5011d2b57575b8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d83f8d8) will **decrease** coverage by `0.09%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 83.65% 83.55% -0.10%
==========================================
Files 14 12 -2
Lines 520 517 -3
==========================================
- Hits 435 432 -3
Misses 85 85
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/common/base64.js](https://codecov.io/gh/apache/cordova-js/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbW1vbi9iYXNlNjQuanM=) | `100.00% <100.00%> (ø)` | |
| [test/test-platform-modules/exec.js](https://codecov.io/gh/apache/cordova-js/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC90ZXN0LXBsYXRmb3JtLW1vZHVsZXMvZXhlYy5qcw==) | | |
| [test/test-platform-modules/platform.js](https://codecov.io/gh/apache/cordova-js/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC90ZXN0LXBsYXRmb3JtLW1vZHVsZXMvcGxhdGZvcm0uanM=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d83f8d8...4c4eea9](https://codecov.io/gh/apache/cordova-js/pull/243?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org