You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by alrick87 <gi...@git.apache.org> on 2016/03/09 17:57:51 UTC
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
GitHub user alrick87 opened a pull request:
https://github.com/apache/brooklyn-dist/pull/13
Add packaging to pom modules, fix version
Adding packaging as module to brooklyn-dist pom.xml.
Also fixing version and artifact name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alrick87/brooklyn-dist update_pom
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-dist/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit dec978c8096ad00dfbc06d48c8fbf9a54a04b87e
Author: alrick87 <so...@gmail.com>
Date: 2016-03-09T16:52:23Z
Add packaging to pom modules, fix version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194748123
Discussed this with @alrick87, needs changing the `rpm` goal to `attached-rpm`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194413230
Yes, looks good. Interested to understand why you had to change from `${project.version}`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194433596
The build fails locally for me (on OS X 10.11.3) with:
```
[ERROR] Failed to execute goal org.codehaus.mojo:rpm-maven-plugin:2.1.5:rpm (generate-rpm) on project brooklyn-packaging: Unable get system architecture: Error while executing process. Cannot run program "rpm": error=2, No such file or directory -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:rpm-maven-plugin:2.1.5:rpm (generate-rpm) on project brooklyn-packaging: Unable get system architecture
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Unable get system architecture
at org.codehaus.mojo.rpm.RPMHelper.getArch(RPMHelper.java:259)
at org.codehaus.mojo.rpm.AbstractRPMMojo.checkParams(AbstractRPMMojo.java:893)
at org.codehaus.mojo.rpm.AbstractRPMMojo.execute(AbstractRPMMojo.java:688)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
... 20 more
Caused by: org.codehaus.plexus.util.cli.CommandLineException: Error while executing process.
at org.codehaus.plexus.util.cli.Commandline.execute(Commandline.java:675)
at org.codehaus.plexus.util.cli.CommandLineUtils.executeCommandLineAsCallable(CommandLineUtils.java:134)
at org.codehaus.plexus.util.cli.CommandLineUtils.executeCommandLine(CommandLineUtils.java:105)
at org.codehaus.plexus.util.cli.CommandLineUtils.executeCommandLine(CommandLineUtils.java:74)
at org.codehaus.mojo.rpm.RPMHelper.getArch(RPMHelper.java:252)
... 24 more
Caused by: java.io.IOException: Cannot run program "rpm": error=2, No such file or directory
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1047)
at java.lang.Runtime.exec(Runtime.java:617)
at org.codehaus.plexus.util.cli.Commandline.execute(Commandline.java:655)
... 28 more
Caused by: java.io.IOException: error=2, No such file or directory
at java.lang.UNIXProcess.forkAndExec(Native Method)
at java.lang.UNIXProcess.<init>(UNIXProcess.java:184)
at java.lang.ProcessImpl.start(ProcessImpl.java:130)
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1028)
... 30 more
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by alrick87 <gi...@git.apache.org>.
Github user alrick87 commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195461739
@rdowner Creating symlink didn't help, looks like Brooklyn completely ignores logback.xml file. I would need help from the experts on that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/13#discussion_r55552149
--- Diff: packaging/pom.xml ---
@@ -37,14 +37,14 @@
<dependency>
<groupId>org.apache.brooklyn</groupId>
<artifactId>brooklyn-all</artifactId>
- <version>${project.version}</version>
+ <version>0.9.0-SNAPSHOT</version>
--- End diff --
What's the reason for using fixed versions? Using properties makes it easier to support.
If can't do without it, then mark it with <!-- BROOKLYN_VERSION --> tag as done above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/13#discussion_r55552172
--- Diff: packaging/pom.xml ---
@@ -37,14 +37,14 @@
<dependency>
<groupId>org.apache.brooklyn</groupId>
<artifactId>brooklyn-all</artifactId>
- <version>${project.version}</version>
+ <version>0.9.0-SNAPSHOT</version>
</dependency>
<!-- TODO include examples -->
<!-- TODO include documentation -->
<dependency>
<groupId>org.apache.brooklyn</groupId>
<artifactId>brooklyn-test-support</artifactId>
- <version>${project.version}</version>
+ <version>0.9.0-SNAPSHOT</version>
--- End diff --
Same here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194434647
@alrick87 @neykov @johnmccabe does `rpm-maven-plugin` need to be run on a linux machine, or should I be able to build this on my mac?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by alrick87 <gi...@git.apache.org>.
Github user alrick87 commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194412072
@neykov
I added the version flags, is this the correct way to use the project version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195377034
@rdowner see comment from @aledsage above re ports
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by alrick87 <gi...@git.apache.org>.
Github user alrick87 commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194435388
@aledsage
It builds perfectly on my mac, you just need to have ```rpm``` package installed beforehand.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195466457
Thanks @alrick87 and everyone! Merging now. We can then iterate on that with more PRs, as needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by alrick87 <gi...@git.apache.org>.
Github user alrick87 commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194419492
@neykov
When I change entry to ${project.version} it throws an error:
```
[ERROR] The project org.apache.brooklyn:brooklyn-packaging:[unknown-version] (/Users/aleksandr/cloudsoft/brooklyn/brooklyn-dist/packaging/pom.xml) has 1 error
[ERROR] Non-resolvable parent POM for org.apache.brooklyn:brooklyn-packaging:[unknown-version]: Could not find artifact org.apache.brooklyn:brooklyn-dist-root:pom:${project.version} in cloudsoft-artifactory-repo (https://artifactory.cloudsoftcorp.com/libs-release) and 'parent.relativePath' points at wrong local POM @ line 29, column 13 -> [Help 2]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-dist/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195464422
Thanks @alrick87
Confirmed this works for me - I pushed to a private artifactory, and the RPM was created correctly there (at `artifactory/libs-snapshot-local/org/apache/brooklyn/brooklyn-packaging/0.9.0-SNAPSHOT/brooklyn-packaging-0.9.0-20160311.141519-2.rpm`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194747517
@alrick87 @neykov for a local build, the RPM was created in `brooklyn-dist/packaging/target/rpm/apache-brooklyn/RPMS/i386/apache-brooklyn-0.9.0-SNAPSHOT20160309232115.i386.rpm`.
However, when I tried pushing to artifactory then this wasn't included. Any ideas?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by alrick87 <gi...@git.apache.org>.
Github user alrick87 commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194434058
@aledsage
you need to install ```rpm``` package first:
```brew install rpm```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by alrick87 <gi...@git.apache.org>.
Github user alrick87 commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194417933
@neykov
Actually I didn't even know it was ${project.version}. It looked like 0.9.0-SNAPSHOT and 0.9.0 in the config file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195374544
Hi @alrick87. I am very overdue with reviewing this, especially as it was me who was championing an RPM package :flushed:
I'm trying this out but I'm getting this error:
```
[INFO] --- rpm-maven-plugin:2.1.5:attached-rpm (generate-rpm) @ brooklyn-packaging ---
[WARNING] rpm version string truncated to 0.9.0
[INFO] Creating directory /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn
[INFO] Creating directory /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/BUILD
[INFO] Creating directory /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/RPMS
[INFO] Creating directory /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/SOURCES
[INFO] Creating directory /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/SPECS
[INFO] Creating directory /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/SRPMS
[INFO] Creating directory /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/tmp-buildroot
[INFO] Creating directory /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/buildroot
[INFO] Copying files to /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/tmp-buildroot/etc/brooklyn
[INFO] Copying files to /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/tmp-buildroot/etc/brooklyn
[INFO] Copying files to /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/tmp-buildroot/etc/brooklyn
[INFO] Copying files to /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/tmp-buildroot/opt/brooklyn
[INFO] Creating empty directory /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/tmp-buildroot/var/lib/brooklyn
[INFO] Creating empty directory /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/tmp-buildroot/var/log/brooklyn
[INFO] Copying files to /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/tmp-buildroot/etc/systemd/system/multi-user.target.wants
[INFO] Creating spec file /Users/richard/dev/apache/brooklyn/brooklyn-dist/packaging/target/rpm/apache-brooklyn/SPECS/apache-brooklyn.spec
[INFO] Building target platforms: i386-apple-Linux
[INFO]
[INFO]
[INFO] RPM build errors:
[INFO] error: Unable to open temp file.
[INFO] Unable to open temp file.
```
I've tried with both RPM 4.4.9 and 5.4.15. One difference to others is that I use MacPorts instead of Brew, but surely `rpm` is `rpm`...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194748385
If we are adding `rpm` to the build requirements how will this affect windows builds? Do we really want to require rpm executable on the windows path?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194420027
Should keep the first explicit version in the <parent> element.
Then can use the property for the rest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195388591
Ok I have it working now :smile: the good news is that once I had the RPM, installing it was dead easy, and I instantly had a working, password-protected, remotely-accessible Brooklyn service running on port 8081. Which is brilliant!
My comments:
* The architecture is appearing as `i386`. Since the package contains pure Java, could we use `noarch` instead?
* The file `/etc/brooklyn/logback.xml` is not being loaded - log files are being written to /opt/brooklyn. Not sure of the best way to fix this; could the package replace `/opt/brooklyn/conf/logback.xml` with ` symlink to `/etc/brooklyn/logback.xml`?
And a question: when I run `rpm -qi apache-brooklyn` I see this:
```
Name : apache-brooklyn
Version : 0.9.0
Release : SNAPSHOT20160311140805
...
```
I'm a bit concerned by `Version: 0.9.0` and `SNAPSHOT` in the release part. Is there any danger that there could be any confusion over this? e.g. if I install 0.9.0-SNAPSHOT, but then later on 0.9.0 (final) comes out, will it accidentally think the `SNAPSHOT` release is "newer"?
Finally, I notice the `br` client is not there. I presume that is deliberate - that an operator would download the `br` client only to his machine and run it there, instead of on the server?
Great work @alrick87 :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195467299
The failing Jenkins build is not related to this PR:
`[ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack (unpack-client-cli) on project brooklyn-dist: Unable to find artifact. Could not find artifact org.apache.brooklyn:brooklyn-client-cli:zip:bin:0.9.0-SNAPSHOT in Nexus (http://repository.apache.org/snapshots)`
@ahgittin @geomacy @ygy is this jenkins failure something that you're looking into?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195379075
Ah good point @neykov - I didn't look closely enough at that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by alrick87 <gi...@git.apache.org>.
Github user alrick87 commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194937585
@neykov I changed the goal from rpm to attached-rpm and it seems to choose the wrong artifactory server:
```
[ERROR] Failed to execute goal on project brooklyn-packaging: Could not resolve dependencies for project org.apache.brooklyn:brooklyn-packaging:pom:0.9.0-SNAPSHOT: Could not transfer artifact org.apache.brooklyn:brooklyn-policy:jar:0.9.0-20160310.013017-161 from/to apache.snapshots (http://repository.apache.org/snapshots): GET request of: org/apache/brooklyn/brooklyn-policy/0.9.0-SNAPSHOT/brooklyn-policy-0.9.0-20160310.013017-161.jar from apache.snapshots failed: Premature end of Content-Length delimited message body (expected: 194881; received: 48841 -> [Help 1]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194837460
meant to say, if we prefer to flip it so that `just-java` is the default that's not hard. but i think safety first.
someone doing java should probably just dive in to `brooklyn-server` and build that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195467915
@aledsage we are blocked on https://issues.apache.org/jira/browse/INFRA-11392 before the cli can build on apache machines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194837203
this is a good question. we hesitated before requiring `go`, in the end we tentatively concluded:
* the default build *does* build everything
* a maven property allows some parts easily to be skipped, e.g. `-Dno-go-client` (see in uber's `pom`)
* if you're missing a requirement we show a nice error message (see in brooklyn-client `release/build.sh`) explaining
* how to fix
* how to skip
@alrick87 if you `grep -r no-go-client` you should find all the references to
* go being required
* being able to skip it
suggest we do the same for docker images, rpm/deb, eventually npm, anything which isn't pure java.
if we start to have a lot then it might be easier to introduce a `just-java` property which also disables the non-portable build items and simply document that in the "quick build" instructions, with a reference from there to the `maven-build` docs where we detail the properties.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194747210
Can you also update the instructions at http://brooklyn.apache.org/v/0.9.0-SNAPSHOT/dev/env/maven-build.html (or a similar page - i.e. to https://github.com/apache/brooklyn-docs/blob/master/guide/dev/env/maven-build.md) to say about the need for `rpm` on the path, and how to get it. For me, I had to follow the instructions at http://stackoverflow.com/questions/25277878/make-rpm-maven-plugin-work-on-mac-osmavericks/29723957#29723957 to get the normal build to pass on OS X. i.e. `sudo port install rpm`, and adding `%_tmppath /tmp` to the file `$HOME/.rpmmacros`. Use of `brew` didn't work for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by alrick87 <gi...@git.apache.org>.
Github user alrick87 commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195429263
@rdowner Release version is taken automatically from the directrory in ```brooklyn-dist/target/```. Maven release version standards seem to be different from both RPM and DEB, which prefers adding simple digit to the main version as a package release, i.e. ```apache-brooklyn-0.9.0-1```. I don't see a way to do the versioning this way right now, as maven does it very differently.
Valid point on setting arch to ```noarch```, thanks.
Logging seem to be broken, yes. Looks like ```-Dlogback.configurationFile=/etc/brooklyn/logback.xml``` doesn't do its job.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/13#discussion_r55552617
--- Diff: packaging/pom.xml ---
@@ -173,4 +173,8 @@
</plugin>
</plugins>
</build>
+
+ <scm>
+ <tag>brooklyn-dist-0.9.0</tag>
--- End diff --
Should this be shared for the whole dist? Or is it even needed, haven't seen one used elsewhere in the poms.
Again if it's here to stay mark with <!-- BROOKLYN_VERSION -->, and change the version to 0.9.0-SNAPSHOT so that the marker actually works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by alrick87 <gi...@git.apache.org>.
Github user alrick87 commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194939652
@ahgittin @aledsage I added "java" and "rpm" packages as requirements for the rpm build. I'm not sure where to look for a ```-Dno-go-client``` example, it's not in uber's pom and ```grep -ir "no-go-client" ./``` in brooklyn uber directory returns nothing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194940751
@alrick87 The repo looks alright to me, it should upload to apache's repos by default.
If you need a different repo to upload to see how the [release script](https://github.com/cloudsoft/amp/blob/master/dist/scripts/release-make.sh#L271) overrides it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194945382
For the record, installed rpm with brew (version rpm (RPM) 5.4.15) and the build was successful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---