[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #311: modify antlr3 to support timeseries path in the number format

[GitBox <gi...@apache.org>]

jixuan1989 commented on a change in pull request #311: modify antlr3 to support timeseries path in the number format
URL: https://github.com/apache/incubator-iotdb/pull/311#discussion_r307954311
 
 

 ##########
 File path: server/src/main/antlr3/org/apache/iotdb/db/sql/parse/TSLexer.g
 ##########
 @@ -146,25 +146,51 @@ StringLiteral
     )
     ;
 
-//2016-11-16T16:22:33+0800
-DATETIME
-    : Digit+ (MINUS | DIVIDE | DOT) Digit+ (MINUS | DIVIDE | DOT) Digit+ ('T' | WS) Digit+ COLON Digit+ COLON Digit+ (DOT Digit+)? ((PLUS | MINUS) Digit+ COLON Digit+)?
-    ;
-
 NegativeInteger
     :
     '-' Digit+
     ;
 
-NonNegativeInteger
+PositiveInteger
+    :
+    '+' Digit+
+    ;
+
+NegativeFloat
+    :
+    '-' Digit+ DOT Digit+ (('e' | 'E') ('+'|'-')? Digit+)?
 
 Review comment:
   I tried Java:
   ```
     System.out.println(Float.valueOf(".3"));
     System.out.println(Float.valueOf("3."));
   ```
   Java works in these cases.
   
   I am not sure whether we need to support that...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services