[jira] Resolved: (WICKET-2018) Buttom subclasses getForm with a different sematic

["Juergen Donnerstag (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-2018.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4-RC2
         Assignee: Juergen Donnerstag

fixed

> Buttom subclasses getForm with a different sematic
> --------------------------------------------------
>
>                 Key: WICKET-2018
>                 URL: https://issues.apache.org/jira/browse/WICKET-2018
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4-RC1
>            Reporter: Juergen Donnerstag
>            Assignee: Juergen Donnerstag
>             Fix For: 1.4-RC2
>
>
> Button.getForm() looks like
> 	public Form<?> getForm()
> 	{
> 		try
> 		{
> 			return super.getForm();
> 		}
> 		catch (WicketRuntimeException wre)
> 		{
> 			// ignore this and return null. (Form.findSubmittingComponent expects this)
> 		}
> 		return null;
> 	}
> Obviously just because Form.findSubmittingComponent expects it. Instead of having different semantics per FormComponent.getForm, findSubmittingComponent should handle it. This is a good case for making a method final.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.