You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/14 22:25:20 UTC

[GitHub] [beam] robertwb commented on a change in pull request #14991: [BEAM-12475] Reject splits for previous bundles.

robertwb commented on a change in pull request #14991:
URL: https://github.com/apache/beam/pull/14991#discussion_r651317762



##########
File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/BeamFnDataReadRunnerTest.java
##########
@@ -178,7 +179,7 @@ public void testCreatingAndProcessingBeamFnDataReadRunner() throws Exception {
               null /* beamFnTimerClient */,

Review comment:
       https://github.com/apache/beam/pull/15011
   
   I would not be oppose to adding additional locking to ProcessBundleHandler, but in general we try to avoid locks while invoking user code so this seems to imply we still need to have locking in BeamFnDataReadRunner (as well as it being good practice to guard against internal access of private variables that may be accessed from multiple threads).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org