[GitHub] [incubator-doris] lingbin commented on a change in pull request #2884: Add `sync_dir` interface to Env

[GitBox <gi...@apache.org>]

lingbin commented on a change in pull request #2884: Add `sync_dir` interface to Env
URL: https://github.com/apache/incubator-doris/pull/2884#discussion_r378052044
 
 

 ##########
 File path: be/src/env/env.h
 ##########
 @@ -139,9 +138,21 @@ class Env {
     // Delete the named file.
     virtual Status delete_file(const std::string& fname) = 0;
 
-    // Create the specified directory. Returns error if directory exists.
+    // Create the specified directory.
+    // NOTE: It will return error if the path already exist(not necessarily as a directory)
     virtual Status create_dir(const std::string& dirname) = 0;
 
 Review comment:
   You may be misunderstood, `"not necessarily as a directory"` means for the case where pathname is a symbolic link, dangling, and so on,  this method will return error too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org