You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl@perl.apache.org by Stas Bekman <st...@stason.org> on 2004/08/19 21:17:37 UTC
[RELEASE CANDIDATE] Apache-Test 1.13
You can download the release candidate from here:
http://www.apache.org/~stas/Apache-Test-1.13-dev.tar.gz
If there are no problems reported Apache-Test 1.13 will be
released tomorrow.
Thanks.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
--
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by Stas Bekman <st...@stason.org>.
William McKee wrote:
> On Wed, Aug 25, 2004 at 05:59:16PM -0700, Stas Bekman wrote:
>
>>Heh, it's so much easier when you have a reproducable case to work on.
>
>
> Believe me, I know; I ask my clients for reproducible cases all the
> time. I'm starting to learn some tricks for tracking down problems like
> this one. Hopefully my reports will be better in the future.
No worries :)
>>Meanwhile I've committed another workaround, please either use the cvs
>>version or apply this patch and let me know whether the problem is still
>>there:
>
>
> This version works fine for me with the test cases I submitted. Glad to
> have that issue out of the way now <g>.
Excellent!
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by William McKee <wi...@knowmad.com>.
On Wed, Aug 25, 2004 at 05:59:16PM -0700, Stas Bekman wrote:
> Heh, it's so much easier when you have a reproducable case to work on.
Believe me, I know; I ask my clients for reproducible cases all the
time. I'm starting to learn some tricks for tracking down problems like
this one. Hopefully my reports will be better in the future.
> Here is the reduced version of your test independent of A-T:
Ahh, now I see. I'll be interested to hear the outcome from the p5p
list.
> Meanwhile I've committed another workaround, please either use the cvs
> version or apply this patch and let me know whether the problem is still
> there:
This version works fine for me with the test cases I submitted. Glad to
have that issue out of the way now <g>.
Thanks!
William
--
Knowmad Services Inc.
http://www.knowmad.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by Stas Bekman <st...@stason.org>.
Meanwhile I've committed another workaround, please either use the cvs
version or apply this patch and let me know whether the problem is still
there:
Index: lib/Apache/TestRun.pm
===================================================================
RCS file:
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.179
diff -u -r1.179 TestRun.pm
--- lib/Apache/TestRun.pm 13 Aug 2004 01:38:49 -0000 1.179
+++ lib/Apache/TestRun.pm 26 Aug 2004 01:16:07 -0000
@@ -640,7 +640,8 @@
$orig_command = "ulimit -c unlimited; $orig_command";
warning "setting ulimit to allow core files\n$orig_command";
exec $orig_command;
- die "exec $orig_command has failed"; # shouldn't be reached
+ # use CORE::die to avoid warnings due to possible overrides of die
+ CORE::die "exec $orig_command has failed"; # shouldn't be reached
}
sub set_ulimit {
@@ -744,7 +745,8 @@
chdir $orig_cwd;
warning "rerunning '$orig_command' with new config opts";
exec $orig_command;
- die "exec $orig_command has failed"; # shouldn't be reached
+ # use CORE::die to avoid warnings due to possible overrides of die
+ CORE::die "exec $orig_command has failed"; # shouldn't be reached
}
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by Stas Bekman <st...@stason.org>.
William McKee wrote:
> On Tue, Aug 24, 2004 at 01:35:48PM -0400, William McKee wrote:
>
>>>was there supposed to be an attachment or something?
>>
>>Dangit! Let's try that again...
>
>
> OK, something funny is going on. My attachments seem to be getting
> stripped. I'm going to inline the code in this email.
>
>
> William
>
> ---------------
>
> ## FILE: statement_not_reached_OK.t
> #!/usr/bin/perl
> use strict;
> no strict 'refs';
> use warnings;
> use Test::More;
> plan tests => 1;
> use Apache::TestUtil;
> use Apache::TestRequest;
> # This is OK
> use CGI::Carp;
> ok 1;
>
>
>
> ## FILE: statement_not_reached.t
> #!/usr/bin/perl
> use strict;
> no strict 'refs';
> use warnings;
> use Test::More;
> plan tests => 1;
> # Calling CGI::Carp before loading Apache::* fails
> use CGI::Carp;
> use Apache::TestUtil;
> use Apache::TestRequest;
> ok 1;
Heh, it's so much easier when you have a reproducable case to work on.
Here is the reduced version of your test independent of A-T:
use strict;
use warnings;
BEGIN {
require Carp;
*CORE::GLOBAL::die = \&CGI::Carp::die;
}
exec "echo OK";
die "shouldnot be reached";
It shouldn't fail, but it fails. Why? Reading:
perldoc -f exec:
[...]
Since it's a common mistake to use "exec" instead of "system",
Perl warns you if there is a following statement which isn't
"die", "warn", or "exit" (if "-w" is set - but you always do
that).
but if someone overrides CORE::die it fails to recognize that.
I thought an explicit:
no warnings 'exit'; will work, but it doesn't.
I'll take it to p5p and let you know the outcoming.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by William McKee <wi...@knowmad.com>.
On Tue, Aug 24, 2004 at 01:35:48PM -0400, William McKee wrote:
> > was there supposed to be an attachment or something?
>
> Dangit! Let's try that again...
OK, something funny is going on. My attachments seem to be getting
stripped. I'm going to inline the code in this email.
William
---------------
## FILE: statement_not_reached_OK.t
#!/usr/bin/perl
use strict;
no strict 'refs';
use warnings;
use Test::More;
plan tests => 1;
use Apache::TestUtil;
use Apache::TestRequest;
# This is OK
use CGI::Carp;
ok 1;
## FILE: statement_not_reached.t
#!/usr/bin/perl
use strict;
no strict 'refs';
use warnings;
use Test::More;
plan tests => 1;
# Calling CGI::Carp before loading Apache::* fails
use CGI::Carp;
use Apache::TestUtil;
use Apache::TestRequest;
ok 1;
--
Knowmad Services Inc.
http://www.knowmad.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by William McKee <wi...@knowmad.com>.
On Mon, Aug 23, 2004 at 08:20:39PM -0700, Stas Bekman wrote:
> >OK, I have a reproducible set of tests which work the same on Win* and
> >Linux. The problem has to do with bringing CGI::Carp into play. Here are
> >two additional tests--one works and the other fails. I hope this will
> >help you to resolve the "Statement unlikely to be reached" errors.
> >
> >Apparently under Linux, my test suite was working because I was loading
> >CGI::Carp somewhere along the way. This wasn't the case in Windows.
>
> was there supposed to be an attachment or something?
Dangit! Let's try that again...
Wm
--
Knowmad Services Inc.
http://www.knowmad.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by Stas Bekman <st...@stason.org>.
William McKee wrote:
> On Mon, Aug 23, 2004 at 03:09:26PM -0400, William McKee wrote:
>
>>I find it interesting that the default testsuite doesn't run into this
>>error but that my tests do. I'll try to create a test that causes the
>>error and send it to the list.
>
>
> OK, I have a reproducible set of tests which work the same on Win* and
> Linux. The problem has to do with bringing CGI::Carp into play. Here are
> two additional tests--one works and the other fails. I hope this will
> help you to resolve the "Statement unlikely to be reached" errors.
>
> Apparently under Linux, my test suite was working because I was loading
> CGI::Carp somewhere along the way. This wasn't the case in Windows.
was there supposed to be an attachment or something?
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by William McKee <wi...@knowmad.com>.
On Mon, Aug 23, 2004 at 03:09:26PM -0400, William McKee wrote:
> I find it interesting that the default testsuite doesn't run into this
> error but that my tests do. I'll try to create a test that causes the
> error and send it to the list.
OK, I have a reproducible set of tests which work the same on Win* and
Linux. The problem has to do with bringing CGI::Carp into play. Here are
two additional tests--one works and the other fails. I hope this will
help you to resolve the "Statement unlikely to be reached" errors.
Apparently under Linux, my test suite was working because I was loading
CGI::Carp somewhere along the way. This wasn't the case in Windows.
Thanks,
William
--
Knowmad Services Inc.
http://www.knowmad.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by William McKee <wi...@knowmad.com>.
On Mon, Aug 23, 2004 at 11:47:21AM -0700, Stas Bekman wrote:
> Well, I tried to fix it some time ago, but w/o being able to reproduce it
> I wasn't very successful. If you have ideas to what could be the problem,
> please let us know/send a patch.
I find it interesting that the default testsuite doesn't run into this
error but that my tests do. I'll try to create a test that causes the
error and send it to the list.
> It's interesting that no other win32 user
> has complained about this. Randy, have you possibly seen this?
And what version of Perl/Win* are you using? I'm on WinXP with
ActiveState Perl Build 809.
William
--
Knowmad Services Inc.
http://www.knowmad.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by Stas Bekman <st...@stason.org>.
William McKee wrote:
> On Fri, Aug 20, 2004 at 01:56:05PM -0700, Stas Bekman wrote:
>
>>>>So all the problems you have reported before are now resolved, William?
>>>
>>>
>>>I knew you were going to ask me that <g>! It's not necessarily the case.
>>>I did not do a complete test under Windows using my test suite; I just
>>>ran the basic tests that come with A::T. I'll try to get to that over
>>>the weekend and let you know.
>>
>>Sure. Take your time, William.
>>
>>I think at least the problem of the endless interactive config loop has
>>been solved now.
>
>
> Yes, I'm not seeing that behavior (although I might be specifying the
> httpd path by habit when I run `perl Makefile.PL`).
>
> OK, I tested the new release with my full test suite and am still
> getting "Statement unlikely to be reached" failures in TestRun.pm at
> lines 643 and 747. I'm simply patching this file which works for my
> needs. It seems this is a perl issue under Win32; I'm still running
> 5.8.3 on that platform.
Well, I tried to fix it some time ago, but w/o being able to reproduce it
I wasn't very successful. If you have ideas to what could be the problem,
please let us know/send a patch. It's interesting that no other win32 user
has complained about this. Randy, have you possibly seen this?
The original William's report can be found here:
http://marc.theaimsgroup.com/?t=107895623500002&r=1&w=2
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by William McKee <wi...@knowmad.com>.
On Fri, Aug 20, 2004 at 01:56:05PM -0700, Stas Bekman wrote:
> >>So all the problems you have reported before are now resolved, William?
> >
> >
> >I knew you were going to ask me that <g>! It's not necessarily the case.
> >I did not do a complete test under Windows using my test suite; I just
> >ran the basic tests that come with A::T. I'll try to get to that over
> >the weekend and let you know.
>
> Sure. Take your time, William.
>
> I think at least the problem of the endless interactive config loop has
> been solved now.
Yes, I'm not seeing that behavior (although I might be specifying the
httpd path by habit when I run `perl Makefile.PL`).
OK, I tested the new release with my full test suite and am still
getting "Statement unlikely to be reached" failures in TestRun.pm at
lines 643 and 747. I'm simply patching this file which works for my
needs. It seems this is a perl issue under Win32; I'm still running
5.8.3 on that platform.
William
--
Knowmad Services Inc.
http://www.knowmad.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by Stas Bekman <st...@stason.org>.
William McKee wrote:
> On Fri, Aug 20, 2004 at 11:08:33AM -0700, Stas Bekman wrote:
>
>>>It's working fine for me under both Linux and Windows.
>>
>>Thanks!
>>
>>So all the problems you have reported before are now resolved, William?
>
>
> I knew you were going to ask me that <g>! It's not necessarily the case.
> I did not do a complete test under Windows using my test suite; I just
> ran the basic tests that come with A::T. I'll try to get to that over
> the weekend and let you know.
Sure. Take your time, William.
I think at least the problem of the endless interactive config loop has
been solved now.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by William McKee <wi...@knowmad.com>.
On Fri, Aug 20, 2004 at 11:08:33AM -0700, Stas Bekman wrote:
> >It's working fine for me under both Linux and Windows.
>
> Thanks!
>
> So all the problems you have reported before are now resolved, William?
I knew you were going to ask me that <g>! It's not necessarily the case.
I did not do a complete test under Windows using my test suite; I just
ran the basic tests that come with A::T. I'll try to get to that over
the weekend and let you know.
William
--
Knowmad Services Inc.
http://www.knowmad.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by Stas Bekman <st...@stason.org>.
William McKee wrote:
> On Thu, Aug 19, 2004 at 12:17:37PM -0700, Stas Bekman wrote:
>
>>You can download the release candidate from here:
>>http://www.apache.org/~stas/Apache-Test-1.13-dev.tar.gz
>>
>>If there are no problems reported Apache-Test 1.13 will be
>>released tomorrow.
>
>
> It's working fine for me under both Linux and Windows.
Thanks!
So all the problems you have reported before are now resolved, William?
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by William McKee <wi...@knowmad.com>.
On Thu, Aug 19, 2004 at 12:17:37PM -0700, Stas Bekman wrote:
> You can download the release candidate from here:
> http://www.apache.org/~stas/Apache-Test-1.13-dev.tar.gz
>
> If there are no problems reported Apache-Test 1.13 will be
> released tomorrow.
It's working fine for me under both Linux and Windows.
William
--
Knowmad Services Inc.
http://www.knowmad.com
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by David Wheeler <da...@kineticode.com>.
On Aug 19, 2004, at 12:17 PM, Stas Bekman wrote:
> You can download the release candidate from here:
> http://www.apache.org/~stas/Apache-Test-1.13-dev.tar.gz
All tests pass for me, and it appears to work nicely with my module
that uses Apache::TestMB.
Regards,
David
Re: [RELEASE CANDIDATE] Apache-Test 1.13
Posted by David Wheeler <da...@kineticode.com>.
On Aug 19, 2004, at 12:17 PM, Stas Bekman wrote:
> You can download the release candidate from here:
> http://www.apache.org/~stas/Apache-Test-1.13-dev.tar.gz
All tests pass for me, and it appears to work nicely with my module
that uses Apache::TestMB.
Regards,
David