You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/11/15 21:48:57 UTC

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1147: ZOOKEEPER-3620 Allow to override calls to System.exit in server side code

eolivelli commented on a change in pull request #1147: ZOOKEEPER-3620 Allow to override calls to System.exit in server side code
URL: https://github.com/apache/zookeeper/pull/1147#discussion_r347025021
 
 

 ##########
 File path: excludeFindBugsFilter.xml
 ##########
 @@ -7,8 +7,5 @@
     <!-- this problem is to be addressed in ZOOKEEPER-3227 -->
     <Bug pattern="DM_DEFAULT_ENCODING"/>
 
-    <!-- not really a problem -->
-    <Bug pattern="DM_EXIT"/>
 
 Review comment:
   know we have only one place in code allowed to call directly System.exit, so it is better to enable the rule and suppress it locally

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services