[GitHub] [tvm] masahi commented on a diff in pull request #11922: [PyTorch] [Relay] Add aten::pad

[GitBox <gi...@apache.org>]

masahi commented on code in PR #11922:
URL: https://github.com/apache/tvm/pull/11922#discussion_r907733361


##########
python/tvm/relay/frontend/pytorch.py:
##########
@@ -3142,12 +3178,13 @@ def create_convert_map(self):
             "prim::NumToTensor": self.numtotensor,
             "prim::ImplicitTensorToNum": self.tensortonum,
             "aten::ScalarImplicit": self.tensortonum,
-            "aten::constant_pad_nd": self.make_pad("constant"),
-            "aten::reflection_pad1d": self.make_pad("reflect"),
-            "aten::reflection_pad2d": self.make_pad("reflect"),
-            "aten::replication_pad1d": self.make_pad("edge"),
-            "aten::replication_pad2d": self.make_pad("edge"),
-            "aten::replication_pad3d": self.make_pad("edge"),
+            "aten::pad": self.pad,

Review Comment:
   They should be tested. There are tests like `test_forward_constant_pad1d` and `test_forward_reflection_pad1d()` in `pytorch/test_forward.py`.
   
   Can you test on PT 1.10? This is the version we use on CI. From our earlier conversation, I'm guessing that `aten::pad` is not in PT 1.10, so we cannot test his on CI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org