[jira] [Closed] (SOLR-11233) GC_LOG_OPTS customisation is a little confusing

["Mayya Sharipova (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-11233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mayya Sharipova closed SOLR-11233.
----------------------------------

Closing after the 8.9.0 release

> GC_LOG_OPTS customisation is a little confusing
> -----------------------------------------------
>
>                 Key: SOLR-11233
>                 URL: https://issues.apache.org/jira/browse/SOLR-11233
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>             Fix For: main (9.0), 8.9
>
>         Attachments: SOLR-11233.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> {{GC_LOG_OPTS}} customisation is currently supported but (pre Java 9) the customised settings are supplemented e.g. https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.6.0/solr/bin/solr#L1713
> {code}
> GC_LOG_OPTS+=("$gc_log_flag:$SOLR_LOGS_DIR/solr_gc.log" '-XX:+UseGCLogFileRotation' '-XX:NumberOfGCLogFiles=9' '-XX:GCLogFileSize=20M')
> {code}
> This seems unexpected and confusing. Some ideas for making it less confusing:
> * a new {{GC_LOG_FILE_OPTS}} option
> ** the new option can be customised but if unset it would default to existing behaviour
> * use customised GC_LOG_OPTS 'as is'
> ** this would be a change to existing behaviour i.e. the [solr#L1713|https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.6.0/solr/bin/solr#L1713] settings mentioned above would no longer be appended



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org