You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Elliott Clark (JIRA)" <ji...@apache.org> on 2012/11/19 19:11:59 UTC
[jira] [Created] (HBASE-7185) Create hbase-rpc module
Elliott Clark created HBASE-7185:
------------------------------------
Summary: Create hbase-rpc module
Key: HBASE-7185
URL: https://issues.apache.org/jira/browse/HBASE-7185
Project: HBase
Issue Type: Sub-task
Reporter: Elliott Clark
Assignee: Elliott Clark
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-protocol module
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501603#comment-13501603 ]
Hudson commented on HBASE-7185:
-------------------------------
Integrated in HBase-TRUNK #3554 (See [https://builds.apache.org/job/HBase-TRUNK/3554/])
HBASE-7185 Create hbase-protocol module (Revision 1411922)
Result = FAILURE
eclark :
Files :
* /hbase/trunk/hbase-protocol
* /hbase/trunk/hbase-protocol/pom.xml
* /hbase/trunk/hbase-protocol/src
* /hbase/trunk/hbase-protocol/src/main
* /hbase/trunk/hbase-protocol/src/main/java
* /hbase/trunk/hbase-protocol/src/main/java/org
* /hbase/trunk/hbase-protocol/src/main/java/org/apache
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AccessControlProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AggregateProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterIdProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterStatusProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ComparatorProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FSProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/LoadBalancerProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterAdminProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterMonitorProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MultiRowMutation.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionServerStatusProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/Tracing.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
* /hbase/trunk/hbase-protocol/src/main/protobuf
* /hbase/trunk/hbase-protocol/src/main/protobuf/AccessControl.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Admin.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Aggregate.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/BulkDelete.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Client.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/ClusterId.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/ClusterStatus.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Comparator.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Examples.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/FS.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Filter.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/LoadBalancer.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Master.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/MasterAdmin.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/MasterMonitor.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/MultiRowMutation.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/README.txt
* /hbase/trunk/hbase-protocol/src/main/protobuf/RPC.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/RegionServerStatus.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Tracing.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/ZooKeeper.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/hbase.proto
* /hbase/trunk/hbase-server/pom.xml
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated
* /hbase/trunk/hbase-server/src/main/protobuf
* /hbase/trunk/pom.xml
> Create hbase-protocol module
> ----------------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-rpc module
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500502#comment-13500502 ]
Hadoop QA commented on HBASE-7185:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12554208/HBASE-7185-0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3367//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3367//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3367//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3367//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3367//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-rpc.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3367//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3367//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3367//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3367//console
This message is automatically generated.
> Create hbase-rpc module
> -----------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7185) Create hbase-protocol module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7185:
---------------------------------
Attachment: HBASE-7185-2.patch
Moved to hbase-protocol
> Create hbase-protocol module
> ----------------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7185) Create hbase-rpc module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7185:
---------------------------------
Status: Patch Available (was: Open)
> Create hbase-rpc module
> -----------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7185) Create hbase-rpc module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7185:
---------------------------------
Attachment: HBASE-7185-1.patch
Missed a commit that cleaned up the rpc pom to not depend upon resource listener.
> Create hbase-rpc module
> -----------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-protocol module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502331#comment-13502331 ]
Elliott Clark commented on HBASE-7185:
--------------------------------------
Filed HBASE-7203
> Create hbase-protocol module
> ----------------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7185) Create hbase-rpc module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7185:
---------------------------------
Attachment: HBASE-7185-1.patch
> Create hbase-rpc module
> -----------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-rpc module
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500631#comment-13500631 ]
Hadoop QA commented on HBASE-7185:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12554216/HBASE-7185-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3368//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3368//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3368//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3368//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3368//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-rpc.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3368//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3368//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3368//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3368//console
This message is automatically generated.
> Create hbase-rpc module
> -----------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7185) Create hbase-protocol module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7185:
---------------------------------
Summary: Create hbase-protocol module (was: Create hbase-rpc module)
> Create hbase-protocol module
> ----------------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-rpc module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501356#comment-13501356 ]
stack commented on HBASE-7185:
------------------------------
Highlevel, this is rpc module so why the pb stuff in here? Its scope is messy when it has stuff like ClusterIdProtos and AggregateProtos and zk protos?
Did you have to pull in stuff to make things like AggregateProtos happy?
Is it odd having RegionServerProto in here, in this module that hbase-server, another module downstream on the dependency river, depends on?
Any particular reason you need it beyond what is listed in issue?
It does not move the content of the rpc package? Just the pbs?
So the below makes it so I can skip unit tests in rpc?
<id>skip-rpc-tests</id>
Its a profile? -Pskip-rpc-tests Or I do it w/ -Dskip-rpc-tests=true
Should be in release notes how to do above.
If above is correct, why doesn't skipTests work for this module? It does but you just want flag for skipping rpcs?
> Create hbase-rpc module
> -----------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7185) Create hbase-protocol module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7185:
---------------------------------
Resolution: Fixed
Release Note: Created hbase-protocol module to extract all protobuf files that could be transmitted.
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed revision 1411922.
> Create hbase-protocol module
> ----------------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7185) Create hbase-rpc module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7185:
---------------------------------
Attachment: (was: HBASE-7185-1.patch)
> Create hbase-rpc module
> -----------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-protocol module
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502261#comment-13502261 ]
Gary Helmling commented on HBASE-7185:
--------------------------------------
It looks like some PB generated sources are still under hbase-server:
{noformat}
$ find hbase-server/ -name '*Protos.java'
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/example/generated/BulkDeleteProtos.java
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/example/generated/ExampleProtos.java
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/protobuf/generated/TestDelayedRpcProtos.java
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/protobuf/generated/TestRpcServiceProtos.java
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/protobuf/generated/TestProtos.java
{noformat}
The .proto files for the {{Test*}} classes are still under {{hbase-server}}, so these seem okay:
{noformat}
$ ls hbase-server/src/test/protobuf/
test_delayed_rpc.proto test.proto test_rpc_service.proto
{noformat}
But the {{BulkDelete.proto}} and {{Examples.proto}} files were moved under {{hbase-protocol}}, so it seems like their {{*Protos.java}} files should be moved as well. Just wanted to confirm there wasn't a reason these were left behind. If not, I'll open an issue.
> Create hbase-protocol module
> ----------------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-protocol module
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501887#comment-13501887 ]
Hudson commented on HBASE-7185:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #268 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/268/])
HBASE-7185 Create hbase-protocol module (Revision 1411922)
Result = FAILURE
eclark :
Files :
* /hbase/trunk/hbase-protocol
* /hbase/trunk/hbase-protocol/pom.xml
* /hbase/trunk/hbase-protocol/src
* /hbase/trunk/hbase-protocol/src/main
* /hbase/trunk/hbase-protocol/src/main/java
* /hbase/trunk/hbase-protocol/src/main/java/org
* /hbase/trunk/hbase-protocol/src/main/java/org/apache
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AccessControlProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AggregateProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterIdProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterStatusProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ComparatorProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FSProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/LoadBalancerProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterAdminProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterMonitorProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MultiRowMutation.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionServerStatusProtos.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/Tracing.java
* /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
* /hbase/trunk/hbase-protocol/src/main/protobuf
* /hbase/trunk/hbase-protocol/src/main/protobuf/AccessControl.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Admin.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Aggregate.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/BulkDelete.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Client.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/ClusterId.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/ClusterStatus.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Comparator.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Examples.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/FS.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Filter.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/LoadBalancer.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Master.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/MasterAdmin.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/MasterMonitor.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/MultiRowMutation.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/README.txt
* /hbase/trunk/hbase-protocol/src/main/protobuf/RPC.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/RegionServerStatus.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/Tracing.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/ZooKeeper.proto
* /hbase/trunk/hbase-protocol/src/main/protobuf/hbase.proto
* /hbase/trunk/hbase-server/pom.xml
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated
* /hbase/trunk/hbase-server/src/main/protobuf
* /hbase/trunk/pom.xml
> Create hbase-protocol module
> ----------------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-protocol module
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501424#comment-13501424 ]
Hadoop QA commented on HBASE-7185:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12554391/HBASE-7185-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitTransaction
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3374//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3374//console
This message is automatically generated.
> Create hbase-protocol module
> ----------------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-rpc module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500634#comment-13500634 ]
Elliott Clark commented on HBASE-7185:
--------------------------------------
Seems like all tests passed even though it timed out.
> Create hbase-rpc module
> -----------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-protocol module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502286#comment-13502286 ]
stack commented on HBASE-7185:
------------------------------
[~eclark] Should we make low priority issues then?
> Create hbase-protocol module
> ----------------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-protocol module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502271#comment-13502271 ]
Elliott Clark commented on HBASE-7185:
--------------------------------------
The test ones were left intentionally (moving tests out of hbase-server will be a pretty slow and arduous task). The examples should probably be moved into the hbase-examples module.
> Create hbase-protocol module
> ----------------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-protocol module
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501510#comment-13501510 ]
stack commented on HBASE-7185:
------------------------------
+1
> Create hbase-protocol module
> ----------------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7185) Create hbase-rpc module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7185:
---------------------------------
Attachment: HBASE-7185-0.patch
Move Protobuf files into hbase-rpc module.
This new module should make it easy for others to interact with hbase-server without depending on much from hbase. Eg this could be used by something like async hbase.
> Create hbase-rpc module
> -----------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7185) Create hbase-rpc module
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501365#comment-13501365 ]
Elliott Clark commented on HBASE-7185:
--------------------------------------
Talked with stack and I think we both agree that rpc is probably a bad name for this module. Thinking hbase-protocol would be better. It would convey more that this module contains only the code of protobuf's that are pushed across the wire to ZK and to/from the servers. That's also why the ipc namespace is not moved into this module. The ipc module it much more tied to our client and server implementations. I wanted to make it possible for an external client to use this module.
The skipping stuff is copied from the rest of the modules. -Dskip-server-tests will skip the server tests, -Dskip-common-tests will skip common etc.
> Create hbase-rpc module
> -----------------------
>
> Key: HBASE-7185
> URL: https://issues.apache.org/jira/browse/HBASE-7185
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from a server) will be stored. This should allow others to create clients without relying on too much of the hbase code base.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira