You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by nk...@apache.org on 2019/08/14 07:30:25 UTC

[pulsar] branch master updated: Do not log stack trace with warn log in websocket proxy (#4945)

This is an automated email from the ASF dual-hosted git repository.

nkurihar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 88e6b2b  Do not log stack trace with warn log in websocket proxy (#4945)
88e6b2b is described below

commit 88e6b2bc5707cd426bede75db43f96f405197375
Author: Masahiro Sakamoto <ma...@yahoo-corp.jp>
AuthorDate: Wed Aug 14 16:30:18 2019 +0900

    Do not log stack trace with warn log in websocket proxy (#4945)
---
 .../src/main/java/org/apache/pulsar/websocket/ProducerHandler.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ProducerHandler.java b/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ProducerHandler.java
index b5fdd8a..6ecf07e 100644
--- a/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ProducerHandler.java
+++ b/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ProducerHandler.java
@@ -260,7 +260,7 @@ public class ProducerHandler extends AbstractWebSocketHandler {
             getSession().getRemote().sendString(msg, new WriteCallback() {
                 @Override
                 public void writeFailed(Throwable th) {
-                    log.warn("[{}] Failed to send ack {}", producer.getTopic(), th.getMessage(), th);
+                    log.warn("[{}] Failed to send ack: {}", producer.getTopic(), th.getMessage());
                 }
 
                 @Override
@@ -272,9 +272,9 @@ public class ProducerHandler extends AbstractWebSocketHandler {
                 }
             });
         } catch (JsonProcessingException e) {
-            log.warn("[{}] Failed to generate ack json-response {}", producer.getTopic(), e.getMessage(), e);
+            log.warn("[{}] Failed to generate ack json-response: {}", producer.getTopic(), e.getMessage());
         } catch (Exception e) {
-            log.warn("[{}] Failed to send ack {}", producer.getTopic(), e.getMessage(), e);
+            log.warn("[{}] Failed to send ack: {}", producer.getTopic(), e.getMessage());
         }
     }