You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <de...@geronimo.apache.org> on 2005/09/11 06:36:30 UTC

[jira] Created: (GERONIMO-1003) Make gbean attributes manageable by default

Make gbean attributes manageable by default
-------------------------------------------

         Key: GERONIMO-1003
         URL: http://issues.apache.org/jira/browse/GERONIMO-1003
     Project: Geronimo
        Type: Improvement
  Components: kernel  
    Versions: 1.0-M5    
    Reporter: David Jencks
 Assigned to: David Jencks 
     Fix For: 1.0-M5


I originally thought attributes should be non-manageable by default, but experience and conversation with others has convinced me that they should be manageable by default, and you can explicitly make them non-manageable in the gbean info.  You still won't be able to change them unless there is a property editor for the type of the attribute.  I'm opening this issue to make it easy to find the change and revert in case someone objects.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-1003) Make gbean attributes manageable by default

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1003?page=all ]
     
David Jencks closed GERONIMO-1003:
----------------------------------

    Resolution: Fixed

Sending        modules/kernel/src/java/org/apache/geronimo/gbean/runtime/GBeanAttribute.java
Transmitting file data .
Committed revision 280071.

> Make gbean attributes manageable by default
> -------------------------------------------
>
>          Key: GERONIMO-1003
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1003
>      Project: Geronimo
>         Type: Improvement
>   Components: kernel
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> I originally thought attributes should be non-manageable by default, but experience and conversation with others has convinced me that they should be manageable by default, and you can explicitly make them non-manageable in the gbean info.  You still won't be able to change them unless there is a property editor for the type of the attribute.  I'm opening this issue to make it easy to find the change and revert in case someone objects.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Reopened: (GERONIMO-1003) Make gbean attributes manageable by default

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1003?page=all ]
     
David Jencks reopened GERONIMO-1003:
------------------------------------


Aaron pointed out that non-persistent manageable doesn't make any sense.

> Make gbean attributes manageable by default
> -------------------------------------------
>
>          Key: GERONIMO-1003
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1003
>      Project: Geronimo
>         Type: Improvement
>   Components: kernel
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> I originally thought attributes should be non-manageable by default, but experience and conversation with others has convinced me that they should be manageable by default, and you can explicitly make them non-manageable in the gbean info.  You still won't be able to change them unless there is a property editor for the type of the attribute.  I'm opening this issue to make it easy to find the change and revert in case someone objects.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-1003) Make gbean attributes manageable by default

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1003?page=all ]
     
David Jencks closed GERONIMO-1003:
----------------------------------

    Resolution: Fixed

Sending        modules/kernel/src/java/org/apache/geronimo/gbean/GAttributeInfo.java
Transmitting file data .
Committed revision 290538.

patch, int the constructor:
-        this.manageable = manageable;
+        //non persistent attributes cannot be manageable
+        this.manageable = manageable & persistent;


> Make gbean attributes manageable by default
> -------------------------------------------
>
>          Key: GERONIMO-1003
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1003
>      Project: Geronimo
>         Type: Improvement
>   Components: kernel
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> I originally thought attributes should be non-manageable by default, but experience and conversation with others has convinced me that they should be manageable by default, and you can explicitly make them non-manageable in the gbean info.  You still won't be able to change them unless there is a property editor for the type of the attribute.  I'm opening this issue to make it easy to find the change and revert in case someone objects.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-1003) Make gbean attributes manageable by default

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-1003?page=comments#action_12323160 ] 

David Jencks commented on GERONIMO-1003:
----------------------------------------

First change did not actually make attributes manageable.   This does, and makes attributes on Configuration not manageable.

Sending        modules/kernel/src/java/org/apache/geronimo/gbean/GBeanInfoBuilder.java
Sending        modules/kernel/src/java/org/apache/geronimo/kernel/config/Configuration.java
Transmitting file data ..
Committed revision 280084.

> Make gbean attributes manageable by default
> -------------------------------------------
>
>          Key: GERONIMO-1003
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1003
>      Project: Geronimo
>         Type: Improvement
>   Components: kernel
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> I originally thought attributes should be non-manageable by default, but experience and conversation with others has convinced me that they should be manageable by default, and you can explicitly make them non-manageable in the gbean info.  You still won't be able to change them unless there is a property editor for the type of the attribute.  I'm opening this issue to make it easy to find the change and revert in case someone objects.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira