You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/01 06:47:28 UTC

[GitHub] [flink] fapaul commented on pull request #17061: [FLINK-23977][elasticsearch] Added DynamicElasticsearchSink for Dynamic ES Cluster Routing

fapaul commented on pull request #17061:
URL: https://github.com/apache/flink/pull/17061#issuecomment-931955519


   I like the name `DemultiplexingSink`. I am not sure whether the `DynamicSink` is the correct way to start because it implies that the sink will only be available with the Table API which feels wrong although implementing in the DataStream API might require some additional efforts.
   
   Either
   
   - Implement a demux operator which is before the SinkWriter and committer operators (might be problematic in case you need to instantiate new sink operator during runtime)
   - Or pass different routers to the sinkwriter and committer, which has an additional configuration effort because we need different routers for the different operators.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org