You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2021/08/30 17:33:24 UTC
[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17816
Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name
......................................................................
IMPALA-10884: Improve pretty-printing of fragment instance name
The dense format of runtime profile print instance names in single long
lines. It is hard to observe the instance names, especially when a
fragment has many instances. This patch fixes the issue by breaking the
list into multiple lines, one line per instance. We also prefix the
instance names with an index number for easy matching against
pretty-printed counters, events, and info strings.
Testing:
- Fix and pass observability/test_profile_tool.py.
- Manually verify that impala-profile-tool prints the instance names in
multiple lines.
Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
---
M be/src/util/runtime-profile.cc
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_default.expected.txt
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.txt
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_default.expected.txt
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_extended.expected.txt
5 files changed, 176 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/17816/1
--
To view, visit http://gerrit.cloudera.org:8080/17816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
Gerrit-Change-Number: 17816
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17816 )
Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name
......................................................................
IMPALA-10884: Improve pretty-printing of fragment instance name
The dense format of runtime profile print instance names in single long
lines. It is hard to observe the instance names, especially when a
fragment has many instances. This patch fixes the issue by breaking the
list into multiple lines, one line per instance. We also prefix the
instance names with an index number for easy matching against
pretty-printed counters, events, and info strings.
Testing:
- Fix and pass observability/test_profile_tool.py.
- Manually verify that impala-profile-tool prints the instance names in
multiple lines.
Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
Reviewed-on: http://gerrit.cloudera.org:8080/17816
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/runtime-profile.cc
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_default.expected.txt
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.txt
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_default.expected.txt
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_extended.expected.txt
5 files changed, 176 insertions(+), 24 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
Gerrit-Change-Number: 17816
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17816 )
Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9402/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
Gerrit-Change-Number: 17816
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Aug 2021 17:55:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17816 )
Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7439/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
Gerrit-Change-Number: 17816
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Aug 2021 22:56:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17816 )
Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9403/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
Gerrit-Change-Number: 17816
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Aug 2021 18:24:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17816 )
Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
Gerrit-Change-Number: 17816
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Aug 2021 05:05:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17816
to look at the new patch set (#2).
Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name
......................................................................
IMPALA-10884: Improve pretty-printing of fragment instance name
The dense format of runtime profile print instance names in single long
lines. It is hard to observe the instance names, especially when a
fragment has many instances. This patch fixes the issue by breaking the
list into multiple lines, one line per instance. We also prefix the
instance names with an index number for easy matching against
pretty-printed counters, events, and info strings.
Testing:
- Fix and pass observability/test_profile_tool.py.
- Manually verify that impala-profile-tool prints the instance names in
multiple lines.
Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
---
M be/src/util/runtime-profile.cc
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_default.expected.txt
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.txt
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_default.expected.txt
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_extended.expected.txt
5 files changed, 176 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/17816/2
--
To view, visit http://gerrit.cloudera.org:8080/17816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
Gerrit-Change-Number: 17816
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17816 )
Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name
......................................................................
Patch Set 3:
> Patch Set 2: Code-Review+2
>
> This looks good to me
Thank you for the review, Joe!
--
To view, visit http://gerrit.cloudera.org:8080/17816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
Gerrit-Change-Number: 17816
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Aug 2021 15:27:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17816 )
Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name
......................................................................
Patch Set 2: Code-Review+2
This looks good to me
--
To view, visit http://gerrit.cloudera.org:8080/17816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
Gerrit-Change-Number: 17816
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Aug 2021 21:10:09 +0000
Gerrit-HasComments: No