You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/02/22 23:23:30 UTC
[GitHub] [guacamole-client] oxcrag opened a new pull request #473: Added
Norwegian keyboard definition and strings
oxcrag opened a new pull request #473: Added Norwegian keyboard definition and strings
URL: https://github.com/apache/guacamole-client/pull/473
...Also translated some of the other keyboard strings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman commented on a change in pull request
#473: Added Norwegian keyboard definition and strings
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #473: Added Norwegian keyboard definition and strings
URL: https://github.com/apache/guacamole-client/pull/473#discussion_r382955005
##########
File path: guacamole/src/main/webapp/translations/cz.json
##########
@@ -462,6 +462,7 @@
"FIELD_OPTION_SERVER_LAYOUT_SV_SE_QWERTY" : "Švédština (Qwerty)",
"FIELD_OPTION_SERVER_LAYOUT_DA_DK_QWERTY" : "Dánština (Qwerty)",
"FIELD_OPTION_SERVER_LAYOUT_TR_TR_QWERTY" : "Turečtina (Qwerty)",
+ "FIELD_OPTION_SERVER_LAYOUT_NB_NO_QWERTY" : "Norština (Qwerty)",
Review comment:
Same, here - the option should be in the most appropriate place, `DA_DK` notwithstanding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman commented on a change in pull request
#473: Added Norwegian keyboard definition and strings
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #473: Added Norwegian keyboard definition and strings
URL: https://github.com/apache/guacamole-client/pull/473#discussion_r382954968
##########
File path: guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json
##########
@@ -105,7 +105,8 @@
"pt-br-qwerty",
"sv-se-qwerty",
"da-dk-qwerty",
- "tr-tr-qwerty"
+ "tr-tr-qwerty",
+ "nb-no-qwerty"
Review comment:
I know the overall list lacks alphabetical order, but it'd be nice if the new entry were in the best possible place (between `ja-jp-qwerty` and above `pt-br-qwerty`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] oxcrag commented on issue #473: GUACAMOLE-968:
Add Norwegian Keymap
Posted by GitBox <gi...@apache.org>.
oxcrag commented on issue #473: GUACAMOLE-968: Add Norwegian Keymap
URL: https://github.com/apache/guacamole-client/pull/473#issuecomment-590073628
This looks better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services