You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org> on 2017/11/08 22:36:00 UTC

[jira] [Comment Edited] (RATIS-129) Compile protobuf and shade if the shaded source directory is missing

    [ https://issues.apache.org/jira/browse/RATIS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244868#comment-16244868 ] 

Tsz Wo Nicholas Sze edited comment on RATIS-129 at 11/8/17 10:35 PM:
---------------------------------------------------------------------

Reverted the commit.

Resolving this as Not A Problem.


was (Author: szetszwo):
Resolving this as Not A Problem.

> Compile protobuf and shade if the shaded source directory is missing
> --------------------------------------------------------------------
>
>                 Key: RATIS-129
>                 URL: https://issues.apache.org/jira/browse/RATIS-129
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>             Fix For: 0.2.0-alpha
>
>         Attachments: r129_20171103.patch
>
>
> Currently, we uses skipShade to activate protobuf compilation and shading.  It is better to check if the corresponding shaded source directory is missing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)