You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@camel.apache.org by BruceKuiLiu <gi...@git.apache.org> on 2017/10/11 09:16:16 UTC

[GitHub] camel pull request #2024: Replace the keySet iterator with an entrySet itera...

GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/camel/pull/2024

    Replace the keySet iterator with an entrySet iterator.

    The current source code accesses the value of a Map entry of methodMap, using a key that is retrieved from a keySet iterator.
    It is more efficient to use an iterator on the entrySet of the methodMap, to avoid the Map.get(key) lookup.
    http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/camel master4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2024.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2024
    
----
commit c7062bae2e719dfe9444dc67974fa22d0ff4557e
Author: Kui LIU <br...@gmail.com>
Date:   2017-10-11T09:15:23Z

    Replace the keySet iterator with an entrySet iterator.
    
    The current source code accesses the value of a Map entry of methodMap, using a key that is retrieved from a keySet iterator.
    It is more efficient to use an iterator on the entrySet of the methodMap, to avoid the Map.get(key) lookup.
    http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR

----


---

[GitHub] camel pull request #2024: Replace the keySet iterator with an entrySet itera...

Posted by BruceKuiLiu <gi...@git.apache.org>.

Github user BruceKuiLiu closed the pull request at:

    https://github.com/apache/camel/pull/2024


---