You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/01/20 12:01:11 UTC
[GitHub] [drill] nielsbasjes opened a new pull request #2147: [DRILL-7847] Give all maven modules a consistent name
nielsbasjes opened a new pull request #2147:
URL: https://github.com/apache/drill/pull/2147
# [DRILL-7847](https://issues.apache.org/jira/browse/DRILL-7847): Give all maven modules a consistent name
## Description
When building Drill the maven output shows the various modules with names that are inconsistent and hard to read.
Some examples of what is there now:
```
[INFO] Apache Drill Root POM .............................. SUCCESS [ 0.100 s]
[INFO] tools/Parent Pom ................................... SUCCESS [ 0.003 s]
[INFO] tools/freemarker codegen tooling ................... SUCCESS [ 0.002 s]
[INFO] Drill Protocol ..................................... SUCCESS [ 0.002 s]
[INFO] Common (Logical Plan, Base expressions) ............ SUCCESS [ 0.002 s]
[INFO] Logical Plan, Base expressions ..................... SUCCESS [ 0.018 s]
[INFO] exec/Parent Pom .................................... SUCCESS [ 0.002 s]
...
[INFO] exec/JDBC Driver using dependencies ................ SUCCESS [ 0.001 s]
[INFO] JDBC JAR with all dependencies ..................... SUCCESS [ 0.037 s]
[INFO] Drill-on-YARN ...................................... SUCCESS [ 0.002 s]
[INFO] metastore/Drill RDBMS Metastore .................... SUCCESS [ 0.004 s]
[INFO] contrib/kudu-storage-plugin ........................ SUCCESS [ 0.030 s]
```
I propose to have a consistent naming of all modules that is easier for the developer to read and understand.
## Documentation
None.
## Testing
If a developer runs the build the naming of the modules is easier to read and understand.
The initial version here outputs this on a `mvn clean`
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Drill : 1.19.0-SNAPSHOT:
[INFO]
[INFO] Drill : ............................................ SUCCESS [ 0.111 s]
[INFO] Drill : Tools : .................................... SUCCESS [ 0.002 s]
[INFO] Drill : Tools : Freemarker codegen ................. SUCCESS [ 0.002 s]
[INFO] Drill : Protocol ................................... SUCCESS [ 0.003 s]
[INFO] Drill : Common ..................................... SUCCESS [ 0.003 s]
[INFO] Drill : Logical Plan, Base expressions ............. SUCCESS [ 0.006 s]
[INFO] Drill : Exec : ..................................... SUCCESS [ 0.003 s]
[INFO] Drill : Exec : Memory : ............................ SUCCESS [ 0.002 s]
[INFO] Drill : Exec : Memory : Base ....................... SUCCESS [ 0.003 s]
[INFO] Drill : Exec : RPC ................................. SUCCESS [ 0.002 s]
[INFO] Drill : Exec : Vectors ............................. SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : .................................. SUCCESS [ 0.003 s]
[INFO] Drill : Contrib : Data : ........................... SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Data : TPCH Sample ............... SUCCESS [ 0.049 s]
[INFO] Drill : Metastore : ................................ SUCCESS [ 0.002 s]
[INFO] Drill : Metastore : API ............................ SUCCESS [ 0.002 s]
[INFO] Drill : Metastore : Iceberg ........................ SUCCESS [ 0.001 s]
[INFO] Drill : Exec : Java Execution Engine ............... SUCCESS [ 0.002 s]
[INFO] Drill : Exec : JDBC Driver using dependencies ...... SUCCESS [ 0.002 s]
[INFO] Drill : Exec : JDBC JAR with all dependencies ...... SUCCESS [ 0.036 s]
[INFO] Drill : Hadoop YARN ................................ SUCCESS [ 0.002 s]
[INFO] Drill : Metastore : RDBMS Metastore ................ SUCCESS [ 0.004 s]
[INFO] Drill : Contrib : Storage : Kudu ................... SUCCESS [ 0.030 s]
[INFO] Drill : Contrib : Format : XML ..................... SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Storage : HTTP ................... SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Storage : OpenTSDB ............... SUCCESS [ 0.001 s]
[INFO] Drill : Contrib : Storage : Mongo .................. SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Storage : HBase .................. SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Storage : JDBC ................... SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Storage : Hive : ................. SUCCESS [ 0.001 s]
[INFO] Drill : Contrib : Storage : Hive : Exec shaded ..... SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Storage : Hive : Core ............ SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Storage : Kafka .................. SUCCESS [ 0.001 s]
[INFO] Drill : Contrib : Storage : ElasticSearch .......... SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : UDFs ............................. SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Format : Syslog .................. SUCCESS [ 0.001 s]
[INFO] Drill : Contrib : Format : Httpd/Nginx access log .. SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Format : HDF5 .................... SUCCESS [ 0.001 s]
[INFO] Drill : Contrib : Format : SPSS .................... SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Format : LTSV .................... SUCCESS [ 0.001 s]
[INFO] Drill : Contrib : Format : Image ................... SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Format : Esri .................... SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Format : Excel ................... SUCCESS [ 0.001 s]
[INFO] Drill : Contrib : Storage : Druid .................. SUCCESS [ 0.002 s]
[INFO] Drill : Packaging and Distribution Assembly ........ SUCCESS [ 0.002 s]
[INFO] Drill : Contrib : Format : MaprDB .................. SUCCESS [ 0.002 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] nielsbasjes commented on pull request #2147: [DRILL-7847] Give all maven modules a consistent name
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #2147:
URL: https://github.com/apache/drill/pull/2147#issuecomment-764752670
@luocooong I implemented your suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on pull request #2147: [DRILL-7847] Give all maven modules a consistent name
Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2147:
URL: https://github.com/apache/drill/pull/2147#issuecomment-764735760
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on pull request #2147: [DRILL-7847] Give all maven modules a consistent name
Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2147:
URL: https://github.com/apache/drill/pull/2147#issuecomment-763592297
@nielsbasjes
Hi. Is it possible to add a title (and naming method) about the consistent name of module in `/master/docs/dev/DevDocs.md`? Maybe it's friendly for new contributor. thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on pull request #2147: [DRILL-7847] Give all maven modules a consistent name
Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2147:
URL: https://github.com/apache/drill/pull/2147#issuecomment-767286271
@nielsbasjes Please squash commits and I think we're ready to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on a change in pull request #2147: [DRILL-7847] Give all maven modules a consistent name
Posted by GitBox <gi...@apache.org>.
luocooong commented on a change in pull request #2147:
URL: https://github.com/apache/drill/pull/2147#discussion_r561966837
##########
File path: contrib/storage-mongo/pom.xml
##########
@@ -28,7 +28,7 @@
<artifactId>drill-mongo-storage</artifactId>
- <name>contrib/mongo-storage-plugin</name>
+ <name>Drill : Contrib : Storage : Mongo</name>
Review comment:
I recommend that `Mongo` to `MongoDB`
##########
File path: drill-yarn/pom.xml
##########
@@ -28,7 +28,7 @@
<artifactId>drill-yarn</artifactId>
<packaging>jar</packaging>
- <name>Drill-on-YARN</name>
+ <name>Drill : Hadoop YARN</name>
Review comment:
I recommend that `Hadoop YARN` to `On-YARN`
##########
File path: contrib/format-httpd/pom.xml
##########
@@ -26,7 +26,7 @@
<version>1.19.0-SNAPSHOT</version>
</parent>
<artifactId>drill-format-httpd</artifactId>
- <name>contrib/httpd-format-plugin</name>
+ <name>Drill : Contrib : Format : Httpd/Nginx access log</name>
Review comment:
I recommend that `Nginx access log` to `Nginx Access Log`
##########
File path: metastore/rdbms-metastore/pom.xml
##########
@@ -28,7 +28,7 @@
</parent>
<artifactId>drill-rdbms-metastore</artifactId>
- <name>metastore/Drill RDBMS Metastore</name>
+ <name>Drill : Metastore : RDBMS Metastore</name>
Review comment:
I recommend that `RDBMS Metastore` to `RDBMS`
##########
File path: contrib/storage-hive/hive-exec-shade/pom.xml
##########
@@ -29,7 +29,7 @@
<artifactId>drill-hive-exec-shaded</artifactId>
<packaging>jar</packaging>
- <name>contrib/hive-storage-plugin/hive-exec-shaded</name>
+ <name>Drill : Contrib : Storage : Hive : Exec shaded</name>
Review comment:
I recommend that `Exec shaded` to `Exec Shaded`
##########
File path: logical/pom.xml
##########
@@ -29,7 +29,7 @@
<artifactId>drill-logical</artifactId>
<packaging>jar</packaging>
- <name>Logical Plan, Base expressions</name>
+ <name>Drill : Logical Plan, Base expressions</name>
Review comment:
I recommend that `Drill : Logical Plan`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on pull request #2147: [DRILL-7847] Give all maven modules a consistent name
Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2147:
URL: https://github.com/apache/drill/pull/2147#issuecomment-764735760
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] nielsbasjes commented on pull request #2147: [DRILL-7847] Give all maven modules a consistent name
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #2147:
URL: https://github.com/apache/drill/pull/2147#issuecomment-764752670
@luocooong I implemented your suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on a change in pull request #2147: [DRILL-7847] Give all maven modules a consistent name
Posted by GitBox <gi...@apache.org>.
luocooong commented on a change in pull request #2147:
URL: https://github.com/apache/drill/pull/2147#discussion_r561966837
##########
File path: contrib/storage-mongo/pom.xml
##########
@@ -28,7 +28,7 @@
<artifactId>drill-mongo-storage</artifactId>
- <name>contrib/mongo-storage-plugin</name>
+ <name>Drill : Contrib : Storage : Mongo</name>
Review comment:
I recommend that `Mongo` to `MongoDB`
##########
File path: drill-yarn/pom.xml
##########
@@ -28,7 +28,7 @@
<artifactId>drill-yarn</artifactId>
<packaging>jar</packaging>
- <name>Drill-on-YARN</name>
+ <name>Drill : Hadoop YARN</name>
Review comment:
I recommend that `Hadoop YARN` to `On-YARN`
##########
File path: contrib/format-httpd/pom.xml
##########
@@ -26,7 +26,7 @@
<version>1.19.0-SNAPSHOT</version>
</parent>
<artifactId>drill-format-httpd</artifactId>
- <name>contrib/httpd-format-plugin</name>
+ <name>Drill : Contrib : Format : Httpd/Nginx access log</name>
Review comment:
I recommend that `Nginx access log` to `Nginx Access Log`
##########
File path: metastore/rdbms-metastore/pom.xml
##########
@@ -28,7 +28,7 @@
</parent>
<artifactId>drill-rdbms-metastore</artifactId>
- <name>metastore/Drill RDBMS Metastore</name>
+ <name>Drill : Metastore : RDBMS Metastore</name>
Review comment:
I recommend that `RDBMS Metastore` to `RDBMS`
##########
File path: contrib/storage-hive/hive-exec-shade/pom.xml
##########
@@ -29,7 +29,7 @@
<artifactId>drill-hive-exec-shaded</artifactId>
<packaging>jar</packaging>
- <name>contrib/hive-storage-plugin/hive-exec-shaded</name>
+ <name>Drill : Contrib : Storage : Hive : Exec shaded</name>
Review comment:
I recommend that `Exec shaded` to `Exec Shaded`
##########
File path: logical/pom.xml
##########
@@ -29,7 +29,7 @@
<artifactId>drill-logical</artifactId>
<packaging>jar</packaging>
- <name>Logical Plan, Base expressions</name>
+ <name>Drill : Logical Plan, Base expressions</name>
Review comment:
I recommend that `Drill : Logical Plan`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong merged pull request #2147: [DRILL-7847] Give all maven modules a consistent name
Posted by GitBox <gi...@apache.org>.
luocooong merged pull request #2147:
URL: https://github.com/apache/drill/pull/2147
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] nielsbasjes commented on pull request #2147: [DRILL-7847] Give all maven modules a consistent name
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #2147:
URL: https://github.com/apache/drill/pull/2147#issuecomment-767380518
@luocooong Did a rebase on the latest master and squashed the commits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] nielsbasjes commented on pull request #2147: [DRILL-7847] Give all maven modules a consistent name
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #2147:
URL: https://github.com/apache/drill/pull/2147#issuecomment-763607045
Sure, I'll put up a proposal for you to evaluate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org