[GitHub] [spark] zsxwing commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer

[GitBox <gi...@apache.org>]

zsxwing commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer
URL: https://github.com/apache/spark/pull/24382#discussion_r310243335
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterSuite.scala
 ##########
 @@ -286,6 +293,71 @@ object ForeachWriterSuite {
   }
 }
 
+class ForeachWriterAbortSuite extends StreamTest with SharedSQLContext with BeforeAndAfter {
 
 Review comment:
   I think this complicated test suite is not necessary. Could you take a look at the `foreach with error` test in `ForeachWriterSuite` and see if you can write a similar one, such as calling `df.map(_ / 0)` to trigger an error?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org