[jira] [Commented] (AIRFLOW-1820) dagrun.dependency-check metric does not play nice with statsd

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266120#comment-16266120 ] 

ASF subversion and git services commented on AIRFLOW-1820:
----------------------------------------------------------

Commit d4816667e5f3bbed293c86b1a23db5d30cf38f2a in incubator-airflow's branch refs/heads/master from [~wrp]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=d481666 ]

[AIRFLOW-1820] Remove timestamp from metric name

Closes #2792 from wrp/datetime


> dagrun.dependency-check metric does not play nice with statsd
> -------------------------------------------------------------
>
>                 Key: AIRFLOW-1820
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1820
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: core
>            Reporter: William Pursell
>            Assignee: William Pursell
>            Priority: Minor
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The metric dagrun.dependency-check (https://github.com/apache/incubator-airflow/blob/master/airflow/models.py#L4594) is sent to statsd with spaces and colons in the metric name.  This is not ideal for statsd.  (I'm not really sure I see the point of putting a timestamp in a metric name at all!)  We should either do something like Stats.timing("dagrun.dependency-check.{}{:%Y%m%d_%H%M%S}". to use a nicer name, or just drop the timestamp completely.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)