You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Lars Hofhansl (Jira)" <ji...@apache.org> on 2024/12/30 17:41:00 UTC
[jira] [Updated] (PHOENIX-7496) Allow Phoenix to work with modern Python
[ https://issues.apache.org/jira/browse/PHOENIX-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated PHOENIX-7496:
-----------------------------------
Description:
Just tried to compile/run Phoenix after a long while, and noticed that Python 13 removed the pipes package, which has been deprecated for a while.
In case anybody runs into this, here's a trivial patch.
{color:#000000}diff --git a/bin/phoenix_utils.py b/bin/phoenix_utils.py{color}{color:#000000} {color}
{color:#000000}index 48e7a42d5..3781f1906 100755{color}{color:#000000} {color}
{color:#000000}— a/bin/phoenix_utils.py{color}{color:#000000} {color}
{color:#000000}+++ b/bin/phoenix_utils.py{color}{color:#000000} {color}
{color:#18b2b2}@@ -217,8 +217,8 @@{color}{color:#000000} def shell_quote(args):{color}{color:#000000} {color}
{color:#000000} return subprocess.list2cmdline(args){color}{color:#000000} {color}
{color:#000000} else:{color}{color:#000000} {color}
{color:#000000} # pipes module isn't available on Windows{color}{color:#000000} {color}
{color:#b21818}- import pipes{color}{color:#000000} {color}
{color:#b21818}- return " ".join([pipes.quote(tryDecode(v)) for v in args]){color}{color:#000000} {color}
{color:#18b218}+ import shlex{color}{color:#000000} {color}
{color:#18b218}+ return " ".join([shlex.quote(tryDecode(v)) for v in args]){color}
{color:#000000} {color}
was:
Python 13 remove the pipes package, which has been deprecated for a while.
In case anybody runs into this, here's a trivial patch.
{color:#000000}diff --git a/bin/phoenix_utils.py b/bin/phoenix_utils.py{color}{color:#000000} {color}
{color:#000000}index 48e7a42d5..3781f1906 100755{color}{color:#000000} {color}
{color:#000000}--- a/bin/phoenix_utils.py{color}{color:#000000} {color}
{color:#000000}+++ b/bin/phoenix_utils.py{color}{color:#000000} {color}
{color:#18b2b2}@@ -217,8 +217,8 @@{color}{color:#000000} def shell_quote(args):{color}{color:#000000} {color}
{color:#000000} return subprocess.list2cmdline(args){color}{color:#000000} {color}
{color:#000000} else:{color}{color:#000000} {color}
{color:#000000} # pipes module isn't available on Windows{color}{color:#000000} {color}
{color:#b21818}- import pipes{color}{color:#000000} {color}
{color:#b21818}- return " ".join([pipes.quote(tryDecode(v)) for v in args]){color}{color:#000000} {color}
{color:#18b218}+ import shlex{color}{color:#000000} {color}
{color:#18b218}+ return " ".join([shlex.quote(tryDecode(v)) for v in args]){color}
{color:#000000} {color}
> Allow Phoenix to work with modern Python
> ----------------------------------------
>
> Key: PHOENIX-7496
> URL: https://issues.apache.org/jira/browse/PHOENIX-7496
> Project: Phoenix
> Issue Type: Bug
> Components: python
> Affects Versions: 5.2.1
> Reporter: Lars Hofhansl
> Priority: Major
>
> Just tried to compile/run Phoenix after a long while, and noticed that Python 13 removed the pipes package, which has been deprecated for a while.
> In case anybody runs into this, here's a trivial patch.
> {color:#000000}diff --git a/bin/phoenix_utils.py b/bin/phoenix_utils.py{color}{color:#000000} {color}
> {color:#000000}index 48e7a42d5..3781f1906 100755{color}{color:#000000} {color}
> {color:#000000}— a/bin/phoenix_utils.py{color}{color:#000000} {color}
> {color:#000000}+++ b/bin/phoenix_utils.py{color}{color:#000000} {color}
> {color:#18b2b2}@@ -217,8 +217,8 @@{color}{color:#000000} def shell_quote(args):{color}{color:#000000} {color}
> {color:#000000} return subprocess.list2cmdline(args){color}{color:#000000} {color}
> {color:#000000} else:{color}{color:#000000} {color}
> {color:#000000} # pipes module isn't available on Windows{color}{color:#000000} {color}
> {color:#b21818}- import pipes{color}{color:#000000} {color}
> {color:#b21818}- return " ".join([pipes.quote(tryDecode(v)) for v in args]){color}{color:#000000} {color}
> {color:#18b218}+ import shlex{color}{color:#000000} {color}
> {color:#18b218}+ return " ".join([shlex.quote(tryDecode(v)) for v in args]){color}
> {color:#000000} {color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)