You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/02/20 21:56:57 UTC

Re: Review Request: Fixed initialization of slave resources

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8171/#review16794
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/8171/#comment35677>

    removed the temps.



src/slave/slave.cpp
<https://reviews.apache.org/r/8171/#comment35678>

    pull the constants up into constants.cpp


- Vinod Kone


On Jan. 19, 2013, 2:06 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8171/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 2:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> Now we properly set cpu/mem/disk/ports based on what's missing in slave flags.
> 
> Also moved usage from os to fs.
> 
> 
> This addresses bug MESOS-318.
>     https://issues.apache.org/jira/browse/MESOS-318
> 
> 
> Diffs
> -----
> 
>   src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
>   src/slave/slave.cpp 9755b46f97173d6fcc9ab1fd63e0e4814b3bc018 
>   src/tests/exception_tests.cpp 13355d08788432ed07679daf24c2d74cc12a7f11 
>   third_party/libprocess/include/stout/fs.hpp 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d 
>   third_party/libprocess/include/stout/os.hpp 76e5e0624af36a0021755fb4acf7f76bfb81a823 
> 
> Diff: https://reviews.apache.org/r/8171/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>