You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/12 15:52:33 UTC

[GitHub] [beam] aromanenko-dev edited a comment on pull request #13975: [BEAM-11806] Explicit Partition Support for KafkaIO.WriteRecords

aromanenko-dev edited a comment on pull request #13975:
URL: https://github.com/apache/beam/pull/13975#issuecomment-778275873


   Rion, please add your test into `org.apache.beam.sdk.io.kafka.KafkaIOTest`, we used to use for KafkaIO unit testing in general. I believe it already contains some tests for `ProducerRecord` sink - please, take a look on `testRecordsSink()`, for example. I think it can be just adjusted to check that right partition was properly set in `ProducerRecord`s.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org