You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by bo...@apache.org on 2010/10/11 11:53:02 UTC
svn commit: r1021293 -
/myfaces/maven/trunk/build-tools/src/main/resources/org/apache/myfaces/tobago/checkstyle.xml
Author: bommel
Date: Mon Oct 11 09:53:02 2010
New Revision: 1021293
URL: http://svn.apache.org/viewvc?rev=1021293&view=rev
Log:
update rule to checkstyle 5.0
Modified:
myfaces/maven/trunk/build-tools/src/main/resources/org/apache/myfaces/tobago/checkstyle.xml
Modified: myfaces/maven/trunk/build-tools/src/main/resources/org/apache/myfaces/tobago/checkstyle.xml
URL: http://svn.apache.org/viewvc/myfaces/maven/trunk/build-tools/src/main/resources/org/apache/myfaces/tobago/checkstyle.xml?rev=1021293&r1=1021292&r2=1021293&view=diff
==============================================================================
--- myfaces/maven/trunk/build-tools/src/main/resources/org/apache/myfaces/tobago/checkstyle.xml (original)
+++ myfaces/maven/trunk/build-tools/src/main/resources/org/apache/myfaces/tobago/checkstyle.xml Mon Oct 11 09:53:02 2010
@@ -60,6 +60,38 @@
<!-- See http://checkstyle.sf.net/config_misc.html#Translation -->
<module name="Translation"/>
+ <module name="FileLength"/>
+
+ <!-- Checks for Headers -->
+ <!-- See http://checkstyle.sf.net/config_header.html -->
+ <module name="RegexpHeader">
+ <property name="headerFile" value="${checkstyle.header.file}"/>
+ </module>
+
+ <module name="FileTabCharacter">
+ <property name="eachLine" value="true"/>
+ </module>
+
+ <module name="RegexpMultiline">
+ <property name="format" value="((public)|(protected))\s+void\s+finalize\(\s*\)"/>
+ <property name="message" value="Avoid finalizers"/>
+ </module>
+
+ <!-- No direct printing to System.out or System.err -->
+ <module name="RegexpMultiline">
+ <property name="format" value="System\.(out|err)\."/>
+ <property name="message" value="Don't write directly to System.out our System.err"/>
+ </module>
+ <!-- No @author tags -->
+ <module name="RegexpMultiline">
+ <property name="format" value="@author"/>
+ <property name="message" value="No @author tag allowed"/>
+ </module>
+
+ <module name="RegexpMultiline">
+ <property name="format" value="strählekreuzen"/>
+ <property name="message" value="No strählekreuzen allowed"/>
+ </module>
<module name="TreeWalker">
@@ -73,9 +105,6 @@
<module name="JavadocVariable"/>
<module name="JavadocStyle"/> -->
-
-
-
<!-- Checks for Naming Conventions. -->
<!-- See http://checkstyle.sf.net/config_naming.html -->
<module name="ConstantName"/>
@@ -88,37 +117,15 @@
<module name="StaticVariableName"/>
<module name="TypeName"/>
-
-
-
- <!-- Checks for Headers -->
- <!-- See http://checkstyle.sf.net/config_header.html -->
- <!-- <module name="Header"> -->
- <!-- The follow property value demonstrates the ability -->
- <!-- to have access to ANT properties. In this case it uses -->
- <!-- the ${basedir} property to allow Checkstyle to be run -->
- <!-- from any directory within a project. See property -->
- <!-- expansion, -->
- <!-- http://checkstyle.sf.net/config.html#properties -->
- <!-- <property -->
- <!-- name="headerFile" -->
- <!-- value="${basedir}/java.header"/> -->
- <!-- Following interprets the header file as regular expressions. -->
- <!-- </module> -->
-
-
-
<!-- Checks for imports -->
<!-- See http://checkstyle.sf.net/config_import.html -->
<module name="AvoidStarImport"/>
- <module name="IllegalImport"/> <!-- defaults to sun.* packages -->
+ <module name="IllegalImport"/>
<module name="RedundantImport"/>
<module name="UnusedImports"/>
-
<!-- Checks for Size Violations. -->
<!-- See http://checkstyle.sf.net/config_sizes.html -->
- <module name="FileLength"/>
<module name="LineLength">
<property name="max" value="120"/>
</module>
@@ -127,7 +134,6 @@
<property name="max" value="15"/>
</module>
-
<!-- Checks for whitespace -->
<!-- See http://checkstyle.sf.net/config_whitespace.html -->
<module name="EmptyForIteratorPad"/>
@@ -137,7 +143,6 @@
<module name="OperatorWrap"/>
<module name="ParenPad"/>
<module name="TypecastParenPad"/>
- <module name="TabCharacter"/>
<module name="WhitespaceAfter"/>
<!--<module name="WhitespaceAround"/>-->
@@ -165,9 +170,10 @@
<!-- See http://checkstyle.sf.net/config_coding.html -->
<!-- <module name="AvoidInlineConditionals"/> -->
<module name="CovariantEquals"/>
- <module name="DoubleCheckedLocking"/> <!-- MY FAVOURITE -->
+ <module name="DoubleCheckedLocking"/>
<!--<module name="EmptyStatement"/>-->
<module name="EqualsHashCode"/>
+ <!--module name="MissingDeprecated"/-->
<!--module name="HiddenField">
<property name="ignoreSetter" value="true" />
<property name=" ignoreConstructorParameter" value="true" />
@@ -176,7 +182,10 @@
<property name="classes" value="java.lang.Boolean, java.lang.String"/>
</module>
<module name="InnerAssignment"/>
- <!-- <module name="MagicNumber"/> -->
+ <!-- <module name="MagicNumber">
+ <!– some numbers are really not that magic –>
+ <property name="ignoreNumbers" value="-4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 32, 64, 100, 128, 256, 512, 1000, 1024"/>
+ </module>-->
<module name="MissingSwitchDefault"/>
<module name="RedundantThrows">
<property name="allowUnchecked" value="true"/>
@@ -199,51 +208,16 @@
<module name="InterfaceIsType"/>
<module name="VisibilityModifier"/>
-
<!-- Miscellaneous other checks. -->
<!-- See http://checkstyle.sf.net/config_misc.html -->
<module name="ArrayTypeStyle"/>
<!--<module name="FinalParameters"/> -->
- <!-- Line with Trailing Spaces (disabled as it's to noisy)
- <module name="GenericIllegalRegexp">
- <property name="format" value="\s+$"/>
- <property name="message" value="Line has trailing spaces."/>
- </module>
- -->
<!-- Let todo plugin handle this.
<module name="TodoComment"/>
-->
- <module name="GenericIllegalRegexp">
- <property name="format" value="((public)|(protected))\s+void\s+finalize\(\s*\)"/>
- <property name="message" value="Avoid finalizers"/>
- </module>
- <!-- No direct printing to System.out or System.err -->
-
-
- <module name="GenericIllegalRegexp">
- <property name="format" value="System\.(out|err)\."/>
- <property name="message" value="Don't write directly to System.out our System.err"/>
- </module>
- <!-- No @author tags -->
- <module name="GenericIllegalRegexp">
- <property name="format" value="@author"/>
- <property name="message" value="No @author tag allowed"/>
- </module>
-
- <module name="GenericIllegalRegexp">
- <property name="format" value="strählekreuzen"/>
- <property name="message" value="No strählekreuzen allowed"/>
- </module>
-
<module name="UpperEll"/>
</module>
- <module name="RegexpHeader">^M
- <property name="headerFile" value="${checkstyle.header.file}"/>^M
- <!--<property name="header" value="^package \n^$\n/\*$\n^ \* Copyright (\d\d\d\d-)?\d\d\d\d The Apache Software Foundation.$\n^ \*$\n^ \* Licensed under the Apache License, Version 2.0 \(the "License"\)\;$\n^ \* you may not use this file except in compliance with the License.$\n^ \* You may obtain a copy of the License at$\n^ \*$\n^ \* http://www.apache.org/licenses/LICENSE-2.0$\n^ \*$\n^ \* Unless required by applicable law or agreed to in writing, software$\n^ \* distributed under the License is distributed on an "AS IS" BASIS,$\n^ \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.$\n^ \* See the License for the specific language governing permissions and$\n^ \* limitations under the License.$\n^ \*/$\n^$"/>-->^M
- </module>^M
-
-
</module>