You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Metastarx (via GitHub)" <gi...@apache.org> on 2026/10/20 15:53:20 UTC

[PR] Add mqadmin getTopicConfig command [rocketmq]

Metastarx opened a new pull request, #11473:
URL: https://github.com/apache/rocketmq/pull/11473

   ### Which Issue(s) This PR Fixes
   
   - Fixes #11472
   
   ### Brief Description
   
   Existing mqadmin topic commands only expose routing, queue counts, or offsets, so users cannot inspect the TopicConfig actually stored on a broker. I added a getTopicConfig subcommand that requires a topic and optionally targets one broker or an entire cluster, falling back to brokers registered in the name server when neither target is supplied. It prints queue counts, decoded permissions, filter type, system flag, order state, attributes, and static-topic mapping details, and skips brokers where the topic is absent. I also registered the command, documented its syntax in both CLI guides, and added mocked broker/name-server tests covering option validation, direct execution, clustered execution, all-broker execution, and a broker without topic configuration.
   
   ### How Did You Test This Change?
   
   `mvn test -pl tools` - passed (Tests run: 176, Failures: 0, Errors: 0, Skipped: 5)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add mqadmin getTopicConfig command [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11473:
URL: https://github.com/apache/rocketmq/pull/11473#issuecomment-6299966524

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/11473?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `74.11765%` with `22 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 49.75%. Comparing base ([`57c2dc0`](https://app.codecov.io/gh/apache/rocketmq/commit/57c2dc04f78cc7e73e6b8c9436ee0fff0d0f46c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e8e0b2b`](https://app.codecov.io/gh/apache/rocketmq/commit/e8e0b2ba1f32744ae295b323b45fafcbbe57d450?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/11473?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [.../tools/command/topic/GetTopicConfigSubCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/11473?src=pr&el=tree&filepath=tools%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Ftools%2Fcommand%2Ftopic%2FGetTopicConfigSubCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvdG9waWMvR2V0VG9waWNDb25maWdTdWJDb21tYW5kLmphdmE=) | 75.00% | [12 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/11473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../apache/rocketmq/tools/command/MQAdminStartup.java](https://app.codecov.io/gh/apache/rocketmq/pull/11473?src=pr&el=tree&filepath=tools%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Ftools%2Fcommand%2FMQAdminStartup.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvTVFBZG1pblN0YXJ0dXAuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/11473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop   #11473      +/-   ##
   =============================================
   + Coverage      49.72%   49.75%   +0.02%     
   - Complexity     14366    14384      +18     
   =============================================
     Files           1390     1391       +1     
     Lines         103264   103349      +85     
     Branches       13504    13518      +14     
   =============================================
   + Hits           51351    51419      +68     
   - Misses         45707    45726      +19     
   + Partials        6206     6204       -2     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/11473?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add mqadmin getTopicConfig command [rocketmq]

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #11473:
URL: https://github.com/apache/rocketmq/pull/11473


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org