[GitHub] [kafka] cadonna commented on a change in pull request #10215: KAFKA-12375: don't reuse thread.id until a thread has fully shut down

[GitBox <gi...@apache.org>]

cadonna commented on a change in pull request #10215:
URL: https://github.com/apache/kafka/pull/10215#discussion_r584613463



##########
File path: checkstyle/suppressions.xml
##########
@@ -161,7 +161,7 @@
               files="StreamThread.java"/>
 
     <suppress checks="ClassDataAbstractionCoupling"
-              files="(KStreamImpl|KTableImpl).java"/>
+              files="(KafkaStreams|KStreamImpl|KTableImpl).java"/>

Review comment:
       Thanks for the proposal! I did not know about that possibility. 
   Every time, I see changes to this file an alarm goes off in my head. I think you are right we need to discuss how much we value the code style rules. In general, I think they are a good sign that we need to refactor our code and I am a bit afraid that we will never do it, if we keep adding suppression rules. In this specific case, I am fine with excluding `AtomicInteger` from the check. At least, we get the error if we add too many references to other objects. Maybe, we should open a newbie ticket each time we think that we add a suppression.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org