You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "mrkm4ntr (via GitHub)" <gi...@apache.org> on 2023/08/10 06:43:38 UTC
[GitHub] [beam] mrkm4ntr commented on a diff in pull request #26424: Handle response exception from Elasticsearch client
mrkm4ntr commented on code in PR #26424:
URL: https://github.com/apache/beam/pull/26424#discussion_r1289632381
##########
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java:
##########
@@ -1224,26 +1241,9 @@ static class DefaultRetryPredicate implements RetryPredicate {
this(429);
}
- /** Returns true if the response has the error code for any mutation. */
- private static boolean errorCodePresent(HttpEntity responseEntity, int errorCode) {
Review Comment:
Thanks.
So, you believe there's a scenario where the HTTP status code is 200, but the status in the body is 429. I'm not certain this is accurate, but we should pay attention to this if we're not confident.
OK, I will change my PR like this.
> Checking the http status code first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org