[GitHub] [flink-docker] zentol commented on a change in pull request #57: [FLINK-21034] Refactor jemalloc switch to environment variable

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #57:
URL: https://github.com/apache/flink-docker/pull/57#discussion_r560855632



##########
File path: docker-entrypoint.sh
##########
@@ -95,40 +94,34 @@ prepare_job_manager_start() {
     envsubst < "${CONF_FILE}" > "${CONF_FILE}.tmp" && mv "${CONF_FILE}.tmp" "${CONF_FILE}"
 }
 
-disable_jemalloc_env() {
-  # use nameref '_args' to update the passed 'args' within function
-  local -n _args=$1
-  if [ "${_args[0]}" = ${COMMAND_DISABLE_JEMALLOC} ]; then
-      echo "Disable Jemalloc as the memory allocator"
-      _args=("${_args[@]:1}")
-  else
-      export LD_PRELOAD=$LD_PRELOAD:/usr/lib/x86_64-linux-gnu/libjemalloc.so
-  fi
+maybe_enable_jemalloc() {

Review comment:
       I disagree. The default in the image is glibc, and we explicitly _enable_ jemalloc unless some condition is met.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org