You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2023/01/10 09:30:12 UTC
[GitHub] [pulsar] tjiuming commented on a diff in pull request #19157: [fix][broker] Close transactionBuffer after MessageDeduplication#checkStatus failed
tjiuming commented on code in PR #19157:
URL: https://github.com/apache/pulsar/pull/19157#discussion_r1065537413
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1599,6 +1599,12 @@ public void openLedgerComplete(ManagedLedger ledger, Object ctx) {
.exceptionally((ex) -> {
log.warn("Replication or dedup check failed."
+ " Removing topic from topics list {}, {}", topic, ex);
+ persistentTopic.getTransactionBuffer()
+ .closeAsync()
+ .exceptionally(t -> {
+ log.error("[{}] Close transactionBuffer failed", topic, t);
+ return null;
Review Comment:
CompletableFuture#exceptionally() requires a `Function` arg
and `Function` requires a return value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org