You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Skiler <gi...@git.apache.org> on 2017/11/29 09:13:45 UTC
[GitHub] activemq-artemis pull request #1679: ARTEMIS-1523 Allow MQTT with dynamic cl...
GitHub user Skiler opened a pull request:
https://github.com/apache/activemq-artemis/pull/1679
ARTEMIS-1523 Allow MQTT with dynamic cluster
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Skiler/activemq-artemis securebranch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1679.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1679
----
commit 1ea3fd90178132d1d23827c01b05df5e153cd141
Author: raul.valdoleiros <ra...@ceiia.com>
Date: 2017-11-24T17:53:14Z
ARTEMIS-1523 Allow MQTT with dynamic cluster
----
---
[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
> For what I have analysed in the artemis code, the message-load-balancing-type is only set for queues configured in the broker.xml.
I don't believe that's true. If you change your example to create subscriptions on "test/1/some/la" instead of "test/+/some/#" and also remove the <addresses> block from the broker.xml files then the address "test/1/some/la" will be created along with the corresponding subscription queues automatically when the client runs. In this situation I can see that the messages are load-balanced properly among the cluster nodes. This leads me to believe that the issue is with how the subscription queues with wildcards (i.e. "test/+/some/#") are interacting with the messages send to a specific address (i.e. "test/1/some/la").
---
[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
It looks a lot better, but you need to squash your commits together into a single commit. Once that's done I'll kick off a full test-suite run with your changes and see how it goes.
---
[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by Skiler <gi...@git.apache.org>.
Github user Skiler commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
I had some problemas with the squash, so I created a new pull request. https://github.com/apache/activemq-artemis/pull/1690
---
[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
It would be ideal to have a real test in the test-suite to validate this functionality instead of just an example. I think that once a test was created you could get rid of the example completely. If you wanted to keep the example after the test was created I would move it to the protocols/mqtt section rather than the features/clustered section.
---
[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
The single commit here is much easier to understand so thanks for that.
However, I don't believe technical solution is viable as it relies on the address for the subscription matching the address in the cluster-connection which would likely only happen if it was specifically configured that way which would preclude other clustered addresses.
I think the real solution would be to address why the message-load-balancing-type isn't being set on the subscription queues in the first place.
---
[GitHub] activemq-artemis pull request #1679: ARTEMIS-1523 Allow MQTT with dynamic cl...
Posted by Skiler <gi...@git.apache.org>.
Github user Skiler closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1679
---
[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by Skiler <gi...@git.apache.org>.
Github user Skiler commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
Hi @jbertram
I changed the way it create the Bindings based in wildcard. I hope it's good now :)
---
[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by Skiler <gi...@git.apache.org>.
Github user Skiler commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
Hi @jbertram
I created a new pull request, I hope it has the needed organization.
Thanks in advance
---
[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by Skiler <gi...@git.apache.org>.
Github user Skiler commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
Hi @jbertram
For what I have analysed in the artemis code, the message-load-balancing-type is only set for queues configured in the broker.xml.
When you publish to an auto created queue it seems the load balancing type isn't set by the postoffice.
So can you help me understand how this is supposed to work in order to fix it? I can do this without using the address and using the value defined in the default cluster connection. What do you think?
Thanks in advance
---