You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/10/26 16:53:45 UTC
[GitHub] [fineract] ankita10r opened a new pull request #1935: FINERACT-1411 Allow charges type saving to map to all types of Ledgers
ankita10r opened a new pull request #1935:
URL: https://github.com/apache/fineract/pull/1935
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1935: FINERACT-1411 Allow charges type saving to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1935:
URL: https://github.com/apache/fineract/pull/1935#issuecomment-953629293
Looks like the build passed. That's great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 merged pull request #1935: FINERACT-1411 Allow charges type saving to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
avikganguly01 merged pull request #1935:
URL: https://github.com/apache/fineract/pull/1935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1935: FINERACT-1411 Allow charges type saving to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1935:
URL: https://github.com/apache/fineract/pull/1935#issuecomment-952861613
@avikganguly01 Travis build triggered - let's see if it is passes
And for local builds you need to always start with a new empty database. Otherwise they will not pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on a change in pull request #1935: FINERACT-1411 Allow charges type saving to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on a change in pull request #1935:
URL: https://github.com/apache/fineract/pull/1935#discussion_r737356282
##########
File path: fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingDropdownReadPlatformServiceImpl.java
##########
@@ -36,7 +36,7 @@
private final GLAccountReadPlatformService accountReadPlatformService;
@Autowired
- public AccountingDropdownReadPlatformServiceImpl(final GLAccountReadPlatformService accountReadPlatformService) {
+ public AccountingDropdownReadPlatformServiceImpl(GLAccountReadPlatformService accountReadPlatformService) {
Review comment:
Assign final.
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountChargeReadPlatformServiceImpl.java
##########
@@ -185,6 +191,23 @@ public SavingsAccountChargeData retrieveSavingsAccountChargeDetails(final Long i
}
}
+ @Override
+ public long retrieveSavingsAccountChargeDetailsId(final Long id, final Long savingsAccountId) {
Review comment:
This function is not called anywhere. Please remove unused code when sending the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on pull request #1935: FINERACT-1411 Allow charges type saving to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on pull request #1935:
URL: https://github.com/apache/fineract/pull/1935#issuecomment-952839801
@ptuomola @awasum : Travis isn't running again. Is this related to bottlenecks on Apache Infra side? If yes, can we move this from Apache infra to some infrastructure which I can provide you access to?
Ankita has tried triggering the build in different ways by pushing commits but no luck so far. Gradle test locally (without the fail fast flag) is failing with some of the flaky tests communicated earlier. We have no way of knowing whether build is going to be triggered and whether it will pass after merging. I have ran the charge specific integration tests separately one by one and they are passing though. I would like to merge it based on the time sensitivity of this rollout in production but I will hold onto it till you get an opportunity to comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #1935: FINERACT-1411 Allow charges type saving to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #1935:
URL: https://github.com/apache/fineract/pull/1935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1935: FINERACT-1411 Allow charges type saving to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1935:
URL: https://github.com/apache/fineract/pull/1935#issuecomment-953459738
Looks like the build failed due to Docker rate limit. Let's retry...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #1935: FINERACT-1411 Allow charges type saving to map to all types of Ledgers
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #1935:
URL: https://github.com/apache/fineract/pull/1935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org