You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/24 12:57:17 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #37266: [WIP][SPARK-39852][SQL][TESTS] Unify v1 and v2 `DESCRIBE TABLE` tests for columns
MaxGekk opened a new pull request, #37266:
URL: https://github.com/apache/spark/pull/37266
### What changes were proposed in this pull request?
Move `DESCRIBE TABLE` parsing tests for columns to `DescribeRelationParserSuite`.
### Why are the changes needed?
1. The unification will allow to run common `DESCRIBE TABLE` columns tests for both DSv1/Hive DSv1 and DSv2
2. We can detect missing features and differences between DSv1 and DSv2 implementations.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By running the modified test suites:
```
$ build/sbt "testOnly *DDLParserSuite"
```
and new test suites:
```
$ build/sbt "sql/test:testOnly *DescribeTableParserSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37266: [SPARK-39852][SQL][TESTS] Unify v1 and v2 `DESCRIBE TABLE` tests for columns
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37266:
URL: https://github.com/apache/spark/pull/37266#issuecomment-1194313180
Merging to master. Thank you, @HyukjinKwon @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37266: [SPARK-39852][SQL][TESTS] Unify v1 and v2 `DESCRIBE TABLE` tests for columns
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37266: [SPARK-39852][SQL][TESTS] Unify v1 and v2 `DESCRIBE TABLE` tests for columns
URL: https://github.com/apache/spark/pull/37266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37266: [SPARK-39852][SQL][TESTS] Unify v1 and v2 `DESCRIBE TABLE` tests for columns
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37266:
URL: https://github.com/apache/spark/pull/37266#issuecomment-1194312703
The failure of [Run / Run TPC-DS queries with SF=1](https://github.com/MaxGekk/spark/runs/7496062914?check_suite_focus=true#logs) is not related to the changes, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org