You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2025/06/05 00:01:09 UTC
[Impala-ASF-CR] IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22982
Change subject: IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
......................................................................
IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
The build was unstable because the "mvn -fae" command in
the java/calcite-planner was removing the jar file due to
the "clean" plugin which was needed because of a mvn bug.
This caused the custom_cluster test_calcite_planner.py test to
fail because it wouldn't find the jar file.
Adding the "install" ensures the jar file will be recreated
after the tests are run.
Change-Id: I04e2c1b9bef26535ca571b87fdbd3e84c61b4b24
---
M bin/run-all-tests.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/22982/1
--
To view, visit http://gerrit.cloudera.org:8080/22982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04e2c1b9bef26535ca571b87fdbd3e84c61b4b24
Gerrit-Change-Number: 22982
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22982 )
Change subject: IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11980/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e2c1b9bef26535ca571b87fdbd3e84c61b4b24
Gerrit-Change-Number: 22982
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Jun 2025 21:50:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22982 )
Change subject: IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19388/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e2c1b9bef26535ca571b87fdbd3e84c61b4b24
Gerrit-Change-Number: 22982
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Jun 2025 00:28:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22982 )
Change subject: IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e2c1b9bef26535ca571b87fdbd3e84c61b4b24
Gerrit-Change-Number: 22982
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jun 2025 03:54:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22982 )
Change subject: IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
......................................................................
IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
The build was unstable because the "mvn -fae" command in
the java/calcite-planner was removing the jar file due to
the "clean" plugin which was needed because of a mvn bug.
This caused the custom_cluster test_calcite_planner.py test to
fail because it wouldn't find the jar file.
Adding the "install" ensures the jar file will be recreated
after the tests are run.
Change-Id: I04e2c1b9bef26535ca571b87fdbd3e84c61b4b24
Reviewed-on: http://gerrit.cloudera.org:8080/22982
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-all-tests.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I04e2c1b9bef26535ca571b87fdbd3e84c61b4b24
Gerrit-Change-Number: 22982
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22982 )
Change subject: IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e2c1b9bef26535ca571b87fdbd3e84c61b4b24
Gerrit-Change-Number: 22982
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Jun 2025 00:26:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22982 )
Change subject: IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e2c1b9bef26535ca571b87fdbd3e84c61b4b24
Gerrit-Change-Number: 22982
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Jun 2025 21:50:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22982 )
Change subject: IMPALA-14041 ADDENDUM: Recreate jar file after tests run.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e2c1b9bef26535ca571b87fdbd3e84c61b4b24
Gerrit-Change-Number: 22982
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Jun 2025 00:11:05 +0000
Gerrit-HasComments: No