You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/08/07 02:15:34 UTC
[GitHub] [kvrocks] git-hulk opened a new issue, #1647: Flaky test in string_test.go
git-hulk opened a new issue, #1647:
URL: https://github.com/apache/kvrocks/issues/1647
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.
### Version
unstable
### Minimal reproduce step
None
### What did you expect to see?
go tests passed
### What did you see instead?
https://github.com/apache/kvrocks/actions/runs/5779002383/job/15660953839#step:12:114
### Anything Else?
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] git-hulk commented on issue #1647: Flaky test in string_test.go
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1647:
URL: https://github.com/apache/kvrocks/issues/1647#issuecomment-1667148962
> our test suite doesn't describe exactly which test case fails. it only says that a failure but there is no clue for us to troubleshoot... can we do anything to improve it?
This should be an issue in the library `testify` which won't show the expected error if the actual error was empty. But from the stack trace line number, we can identify this error was happened at line: https://github.com/apache/kvrocks/blob/06b5558ca6e5401388639ef9130256367dcef9de/tests/gocase/util/server.go#L109
This line expected the signal-killed error after timed reach, but it got nil. I'm not sure if it's a data race between the kill signal and the process exit behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] enjoy-binbin commented on issue #1647: Flaky test in string_test.go
Posted by "enjoy-binbin (via GitHub)" <gi...@apache.org>.
enjoy-binbin commented on issue #1647:
URL: https://github.com/apache/kvrocks/issues/1647#issuecomment-1667140861
our test suite doesn't describe exactly which test case fails.
it only says that a failure but there is no clue for us to troubleshoot...
can we do anything to improve it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] git-hulk commented on issue #1647: Flaky test in string_test.go
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1647:
URL: https://github.com/apache/kvrocks/issues/1647#issuecomment-1670627470
After reading the Go `timer.Stop` documentation, the second issue it's caused by timer.Stop won't wait for the timer routine if the time was expired. Let me fix them together later.
```
// For a timer created with AfterFunc(d, f), if t.Stop returns false, then the timer
// has already expired and the function f has been started in its own goroutine;
// Stop does not wait for f to complete before returning.
// If the caller needs to know whether f is completed, it must coordinate
// with f explicitly.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] git-hulk commented on issue #1647: Flaky test in string_test.go
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1647:
URL: https://github.com/apache/kvrocks/issues/1647#issuecomment-1670622350
Thanks @enjoy-binbin helps to paste the detail information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] git-hulk commented on issue #1647: Flaky test in string_test.go
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1647:
URL: https://github.com/apache/kvrocks/issues/1647#issuecomment-1670595129
Another issue is related to this: https://github.com/apache/kvrocks/actions/runs/5803982834/job/15733157365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] tisonkun closed issue #1647: Flaky test in string_test.go
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed issue #1647: Flaky test in string_test.go
URL: https://github.com/apache/kvrocks/issues/1647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org