You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by "vlsi (via GitHub)" <gi...@apache.org> on 2023/12/23 18:39:52 UTC
[PR] Streamline binding of UI elements to TestElement properties [jmeter]
vlsi opened a new pull request, #6199:
URL: https://github.com/apache/jmeter/pull/6199
## Description
A common theme is as follows:
1. If a property is set from code (e.g. from Java code), then we should store it in `TestElement` properties no matter if the value is empty or if the value is the same as default one. For instance, `HTTP Request Defaults` (and other "config" elements) override non-set properties only, so we might want to explicitly have a value in `HTTP Request` to avoid it being overridden by `HTTP Request Defaults`
2. If a UI element (e.g. `JTextField`) is empty (blank) we assume the value is unset. Currently, we have no way to distinguish between "value is empty string" vs "value is unset", so we just assume "blank" values to be the same as "unset". It means UI elements should convert "empty string text field" and "empty checkbox" to "property removal". Note that we can't integrate "remove empty property" into setter methods due to `1.`
To make it happen without much duplication, I factor UI converters into UI classes. For instance, `JEditableCheckBox` calls into `removeProperty` for unset checkboxes.
I added `JTextFieldBindEditor` to make it easier to teach the existing UI classes to "remove property on empty string"
This change passes tests, however, I need to pass and apply `JTextFieldBindEditor` to `Gui` classes that use `TestElementSchema`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Streamline binding of UI elements to TestElement properties [jmeter]
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi merged PR #6199:
URL: https://github.com/apache/jmeter/pull/6199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Streamline binding of UI elements to TestElement properties [jmeter]
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #6199:
URL: https://github.com/apache/jmeter/pull/6199#issuecomment-1868908305
I'm happy with the changes, except there might be better names for the added classes and methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org