You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/14 06:19:41 UTC

[GitHub] [arrow-rs] matthewmturner commented on pull request #984: Add scalar comparison kernels for DictionaryArray

matthewmturner commented on pull request #984:
URL: https://github.com/apache/arrow-rs/pull/984#issuecomment-993196776


   @alamb @jorgecarleitao  im not familiar enough with the rest of the code base, but would adding a `dyn Scalar` trait mean having to update everywhere rust native scalars are currently used with that trait?  of course this is assuming legal issues are resolved.  on that point, independent from the context of this PR, is IP clearance expected to refresh anytime soon?
   
   The approach from @shepmaster seemed quite nice as well however would still require users setting the type of the scalar - is that acceptable?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org