[GitHub] [hudi] codope commented on a change in pull request #3450: [HUDI-2294] Adding virtual keys props in deltastreamer path

[GitBox <gi...@apache.org>]

codope commented on a change in pull request #3450:
URL: https://github.com/apache/hudi/pull/3450#discussion_r686489245



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -249,14 +251,20 @@ public void refreshTimeline() throws IOException {
     } else {
       this.commitTimelineOpt = Option.empty();
       String partitionColumns = HoodieWriterUtils.getPartitionColumns(keyGenerator);
-
+      LOG.warn("Partition cols " + partitionColumns);
       HoodieTableMetaClient.withPropertyBuilder()
           .setTableType(cfg.tableType)
           .setTableName(cfg.targetTableName)
           .setArchiveLogFolder(HOODIE_ARCHIVELOG_FOLDER_PROP.defaultValue())
           .setPayloadClassName(cfg.payloadClassName)
           .setBaseFileFormat(cfg.baseFileFormat)
           .setPartitionFields(partitionColumns)
+          .setPartitionFields(props.getProperty(DataSourceWriteOptions.PARTITIONPATH_FIELD().key()))

Review comment:
       Partition field is being set twice. Is this necessary?  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org