[I] Let the bottom-up parsers use a caller-supplied POSTagger and Chunker via a builder (opennlp)

["krickert (via GitHub)" <gi...@apache.org>]

krickert opened a new issue, #1476:
URL: https://github.com/apache/opennlp/issues/1476

   The chunking and tree insert parsers always build a POSTaggerME and a ChunkerME from the tagger and chunker models stored in the ParserModel. An application cannot parse with its own tagger or chunker, for example a POS tagger trained on domain text, without training a new parser model.
   
   Both parsers should get a public constructor that takes a POSTagger and a Chunker next to the ParserModel. The build, attach and check models and the head rules still come from the model, and the model's own tagger and chunker are not constructed. ParserFactory.builder(model) should return a ParserBuilder with tagger(), chunker(), beamSize() and advancePercentage(), falling back to the model's components for anything not set, and ParserFactory.create should go through it so the parser type dispatch exists once.
   
   Arguments should be checked at the public boundary with IllegalArgumentException: a null model, tagger, chunker or head rules, a beam size below 1, and an advance percentage outside (0, 1].


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Let the bottom-up parsers use a caller-supplied POSTagger and Chunker via a builder (opennlp)

["mawiesne (via GitHub)" <gi...@apache.org>]

mawiesne closed issue #1476: Let the bottom-up parsers use a caller-supplied POSTagger and Chunker via a builder
URL: https://github.com/apache/opennlp/issues/1476


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org