You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org> on 2025/12/01 20:24:41 UTC
[Impala-ASF-CR] IMPALA-14131: Add flag to configure the default value of 'impala.disableHmsSync'
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/23487 )
Change subject: IMPALA-14131: Add flag to configure the default value of 'impala.disableHmsSync'
......................................................................
Patch Set 6:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/23487/5/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/23487/5/be/src/catalog/catalog-server.cc@323
PS5, Line 323: all objects
> Can you update the flag description to reflect this? E.g. all objects (with
Ack
http://gerrit.cloudera.org:8080/#/c/23487/5/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:
http://gerrit.cloudera.org:8080/#/c/23487/5/tests/custom_cluster/test_events_custom_configs.py@1849
PS5, Line 1849: self.client.execute("invalidate metadata {}".format(tbl))
: self.client.execute("describe {}".format(tbl))
: self.run_stmt_in_hive(
: """ALTER DATABASE {} SET DBPROPERTIES ('impala.disableHmsSync'='false')"""
: .format(unique_database))
: events_skipped_before = EventProcessorUtils.get_int_metric('events-skipped', 0)
: EventProcessorUtils.wait_for_event_processing(self)
: # modify data externally
: self.run_stmt_in_hive(
> I am not forcing this, but my idea for the function was to use it at multip
Ack
http://gerrit.cloudera.org:8080/#/c/23487/6/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:
http://gerrit.cloudera.org:8080/#/c/23487/6/tests/custom_cluster/test_events_custom_configs.py@1850
PS6, Line 1850: self.client.execute("describe {}".format(tbl))
> I think that DESCRIBE is not the ideal way to do this - this is something t
I thought the other way would happen, describe table fetches only metadata of the table and select would have to load data files
--
To view, visit http://gerrit.cloudera.org:8080/23487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ee617aed48575502d9cf5cf2cbea6ec897d6839
Gerrit-Change-Number: 23487
Gerrit-PatchSet: 6
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 20:24:41 +0000
Gerrit-HasComments: Yes